magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Fix wording of filter item on layered navigation

Open yogesh-valiya opened this issue 2 years ago • 3 comments

Description (*)

The words item and items are incorrectly used in the layered navigation filter item.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

yogesh-valiya avatar Aug 04 '23 18:08 yogesh-valiya

Hi @yogesh-valiya. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Aug 04 '23 18:08 m2-assistant[bot]

@magento run all tests

yogesh-valiya avatar Aug 04 '23 18:08 yogesh-valiya

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

Den4ik avatar May 25 '24 19:05 Den4ik

@magento run all tests

engcom-Bravo avatar Jun 04 '24 03:06 engcom-Bravo

@magento create issue

engcom-Bravo avatar Jun 04 '24 06:06 engcom-Bravo

Hi @yogesh-valiya,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

engcom-Bravo avatar Jun 04 '24 09:06 engcom-Bravo

@magento run all tests

engcom-Charlie avatar Jun 04 '24 10:06 engcom-Charlie

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests

engcom-Charlie avatar Jun 05 '24 06:06 engcom-Charlie

Few test failures in recent 2 runs of functional B2B are different. Below 2 failures are constant in both the builds but these are the known issues.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37852/626cb629076b182295ded290aa873a2a/Functional/allure-report-b2b/index.html#categories/fcae19c49786395b97729f5a28dfab07/a6562602c85b49ed/ image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37852/9500b19ae8a3baf081af3e18fb11460b/Functional/allure-report-b2b/index.html#categories/e89a2ef77b192fa659586970627a6e4a/dd470d803b3cf64c/ image

Known Issues:

  1. AdminReorderWithCatalogPriceRuleDiscountTest: ACQE-6523
  2. StorefrontUpdateCustomerAddressBelgiumTest: ACQE-6648

engcom-Charlie avatar Jun 05 '24 12:06 engcom-Charlie

Few test failures in recent 2 runs of functional EE are different. Below 2 failures are constant in both the builds but these are the known issues. Hence moving this PR to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37852/637586a93d6c47f9e43100b6012b9959/Functional/allure-report-ee/index.html#categories image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37852/416043f374b5f8029ed4d74b7e125768/Functional/allure-report-ee/index.html#categories image

Known Issues:

  1. StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: ACQE-6331
  2. AdminReorderWithCatalogPriceRuleDiscountTest: ACQE-6523

engcom-Charlie avatar Jun 05 '24 13:06 engcom-Charlie