magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Fix HTML syntax error in visual.phtml

Open AntonKryvoruchko opened this issue 2 years ago • 40 comments

Start tag (th) not closed properly, expected '>'.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#38247: Fix HTML syntax error in visual.phtml

AntonKryvoruchko avatar May 03 '23 22:05 AntonKryvoruchko

Hi @AntonKryvoruchko. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar May 03 '23 22:05 m2-assistant[bot]

@magento run all tests

ihor-sviziev avatar May 08 '23 07:05 ihor-sviziev

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

ihor-sviziev avatar May 17 '23 06:05 ihor-sviziev

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

ihor-sviziev avatar Oct 05 '23 11:10 ihor-sviziev

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run Static Tests

ihor-sviziev avatar Oct 06 '23 14:10 ihor-sviziev

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Great! static tests are passing! @magento run all tests

ihor-sviziev avatar Oct 06 '23 15:10 ihor-sviziev

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento create issue

engcom-Delta avatar Dec 06 '23 14:12 engcom-Delta

@magento run all tests

engcom-Delta avatar Dec 07 '23 10:12 engcom-Delta

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

:heavy_check_mark: QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Go to app/code/Magento/Swatches/view/adminhtml/templates/catalog/product/attribute/visual.phtml
  2. Verify 8, 24, 25, 43, 59, 90 and 100th line
  3. The changes should be saved

Before: :heavy_multiplication_x: 

Screenshot 2023-12-07 at 2 20 24 PM Screenshot 2023-12-07 at 2 21 47 PM Screenshot 2023-12-07 at 2 22 24 PM Screenshot 2023-12-07 at 2 23 17 PM

After: :heavy_check_mark:  

Screenshot 2023-12-07 at 3 24 45 PM Screenshot 2023-12-07 at 3 25 44 PM Screenshot 2023-12-07 at 3 26 34 PM Screenshot 2023-12-07 at 3 27 12 PM

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Delta avatar Dec 07 '23 11:12 engcom-Delta

@magento run all tests

engcom-Echo avatar Dec 18 '23 06:12 engcom-Echo

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run WebAPI Tests,Static Tests,Integration Tests,Functional Tests CE,Functional Tests B2B

engcom-Echo avatar Dec 18 '23 08:12 engcom-Echo

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run WebAPI Tests

engcom-Echo avatar Dec 18 '23 11:12 engcom-Echo

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

WebAPI Tests failure does not seems to be related to PR.

Hence moving it to merge in progress

engcom-Echo avatar Dec 18 '23 13:12 engcom-Echo

@magento run WebAPI Tests

engcom-Echo avatar Dec 18 '23 13:12 engcom-Echo

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run WebAPI Tests

engcom-Echo avatar Dec 27 '23 14:12 engcom-Echo

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

engcom-Echo avatar Dec 27 '23 14:12 engcom-Echo

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Let is be noted that there is a competing PR with the same changes over here: https://github.com/magento/magento2/pull/38261

Both got approved, so we should halt one of them and only proceed with one and not with both.

hostep avatar Jan 04 '24 15:01 hostep

@magento run all tests

engcom-Charlie avatar Feb 08 '24 04:02 engcom-Charlie