Character Encoding - Full Name - Welcome, Te'st!

[timpea]

Preconditions and environment

Magento 2.4.5-p1

Steps to reproduce

Create customer account, add ' into name Name: Test Te'st

Expected result

Welcome header greet drop down should show: Welcome Test Te'st!

Actual result

Welcome header greet drop down displays: Welcome, Test Te'st!

Additional information

No response

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [x] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @timpea. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.

• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[m2-assistant[bot]]

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Dash]

@magento give 2.4-develop instance

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Dash, here is your Magento Instance: https://7e584375fb746930c14ece4ca6f8d54f.instances.magento-community.engineering Admin access: https://7e584375fb746930c14ece4ca6f8d54f.instances.magento-community.engineering/admin_cd2e Login: 70972583 Password: 5394023e3208

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Dash, here is your Magento Instance: https://7e584375fb746930c14ece4ca6f8d54f.instances.magento-community.engineering Admin access: https://7e584375fb746930c14ece4ca6f8d54f.instances.magento-community.engineering/admin_c8a2 Login: f64a411f Password: afadc92da1d2

[engcom-Dash]

Hi @timpea ,

Verified the issue in 2.4-develop instance and the issue is reproducible ,Hence we are confirming the issue.

Magento Version 2.4-develop PHP 8.1

Steps: 1.Install magento instance 2.Go to front end 3.Create customer with Name of "Test Te'st".

Screenshots:

we are getting the Actual result as per the description.

Let us know if we missing anything!!!

Thanks!!!

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-7914 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[this-adarsh]

@magento give me 2.4-develop instance

[this-adarsh]

@magento I am working on this

[hostep]

Looks like to be fixed by ACP2E-1602: [Issue] Fixed the welcome message contains single quote character, @this-adarsh: can you confirm this fixes the problem?

[this-adarsh]

Hi @hostep, I checked this PR but it is not escaping the ' character yet, Also escapeQuote() is a deprecated function. I am proposing a solution here https://github.com/magento/magento2/pull/36884 please see if it can be considered.

Thanks

[hostep]

I think the new proposed solution is not good since it uses bindHtml and this isn't supposed to contain html, it's supposed to contain pure text, or am I missing something?

You are right about escapeQuote being deprecated, no idea why they used that method. What would be the correct one to use you think?

[this-adarsh]

I checked https://github.com/magento/magento2/commit/4b5c1dc1382c2e6e144789c49db27c9085146551 and tried to replace the code in my local but i saw no solution(I was still seeing characters like ' printed) so i think we should not worry about it.

for ' is a html character and it is directly printed because data-bind='text: treating it as a text but ultimately it is a HTML thats why i replaced it with bindHtml. I checked for possible XXS scenario as well.

what possible solution you are thinking of @hostep.

[hostep]

I'm not really familiar with knockout (which this is using I think?), but there must be a proper way to escape the ' character besides turning everything into html.

[this-adarsh]

Okay, Currently I can't think more i have overridden similarly for my site. Lets see if any new fix shows up.

[davideleonelli99]

Hello, did someone find a solution? I have the same issue on Adobe Commerce 2.4.7.

[engcom-Bravo]

Hi @timpea,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in latest 2.4-develop instance and the issue is no more reproducible.Kindly refer the screenshots.

Hence we are closing this issue.

Thanks.