magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[GraphQL] Price and Category Aggregation Labels are not translated

Open t-heuser opened this issue 3 years ago • 12 comments

Preconditions and environment

  • Magento version: 2.4.5
  • A store view with any language thats not english

Steps to reproduce

Execute the following graphql query:

query searchProducts {
    products(search: "") {
        aggregations {
            label
        }
    }
}

This query fetches all available aggregations (filters) and the labels for them.

Expected result

I would expect all labels to be translated into the language of the store (german in my case).

{
  "data": {
    "products": {
      "aggregations": [
        {
          "label": "Preis"
        },
        {
          "label": "Kategorie"
        },
        {
          "label": "Farbe"
        },
        {
          "label": "..."
        },
      ]
    }
  }
}

Actual result

{
  "data": {
    "products": {
      "aggregations": [
        {
          "label": "Price"
        },
        {
          "label": "Category"
        },
        {
          "label": "Farbe"
        },
        {
          "label": "..."
        },
      ]
    }
  }
}

Only the label for the attribute color (Farbe) is translated as set in the adminhtml. The label set for the price attribute is ignored and I can't even set any label for the category attribute.

Additional information

The problem arises because of hardcoded labels in the code:

https://github.com/magento/magento2/blob/91549b925da128ba79807400f551f2b2d0cfeed9/app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Category.php#L152-L156

https://github.com/magento/magento2/blob/91549b925da128ba79807400f551f2b2d0cfeed9/app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Category.php#L37-L42

and

https://github.com/magento/magento2/blob/91549b925da128ba79807400f551f2b2d0cfeed9/app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Price.php#L60-L64

https://github.com/magento/magento2/blob/91549b925da128ba79807400f551f2b2d0cfeed9/app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Price.php#L33-L38

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

t-heuser avatar Sep 14 '22 06:09 t-heuser

Hi @oneserv-heuser. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Sep 14 '22 06:09 m2-assistant[bot]

@magento give me 2.4-develop instance

t-heuser avatar Sep 14 '22 06:09 t-heuser

Hi @oneserv-heuser. Thank you for your request. I'm working on Magento instance for you.

Hi @oneserv-heuser, here is your Magento Instance: https://f52c0362d0fdc3db104477f56aabec02.instances.magento-community.engineering Admin access: https://f52c0362d0fdc3db104477f56aabec02.instances.magento-community.engineering/admin_2488 Login: 856c693f Password: fdc0e08d3348

I can confirm the issue on a magento vanilla instance. I set the language for the store to german and translated the labels for the attributes price and color. Price and category are still in english while color is in german now.

t-heuser avatar Sep 14 '22 06:09 t-heuser

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Sep 20 '22 05:09 m2-assistant[bot]

@magento give me 2.4-develop instance

engcom-Bravo avatar Sep 20 '22 10:09 engcom-Bravo

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Bravo, here is your Magento Instance: https://f52c0362d0fdc3db104477f56aabec02.instances.magento-community.engineering Admin access: https://f52c0362d0fdc3db104477f56aabec02.instances.magento-community.engineering/admin_60f1 Login: 913099c3 Password: 50636eb04685

Hi @oneserv-heuser,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop and 2.4.5 instances and the issue is reproducible on both the instances. Price,Color and Category Aggregation labels are not translated.kindly refer the screenshots.

Language of the Store Configured as German.

Screenshot 2022-09-23 at 5 51 35 PM Screenshot 2022-09-23 at 7 13 41 PM

Hence Confirming the issue.

Thanks.

engcom-Bravo avatar Sep 23 '22 12:09 engcom-Bravo

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-6745 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Sep 23 '22 13:09 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Sep 23 '22 13:09 m2-assistant[bot]

@magento I am working on this

Kannakiraj123 avatar Dec 20 '22 06:12 Kannakiraj123

Hi @oneserv-heuser , Development team is currently working on this issue. Thank you.

engcom-November avatar Mar 27 '23 14:03 engcom-November