Issue 36073: Coupon codes export to Excel XML not working as expected

[rogerdz]

Description (*)

Coupon codes export to Excel XML not working as expected

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#36073

Manual testing scenarios (*)

1. Create a salesrule of type "Specific Coupon" and check "Use auto generation"
2. Hit "Save and Continue Edit"
3. Head to "Manage Coupon Codes" Tab and generate e.g. 500 Coupons
4. Hit generate and wait for completion
5. Go to generated coupon code list and hit "Mass actions" -> "Select all"
6. All coupons (500) should now be shown as selected.
7. Choose "Export to CSV" and hit the "Export" button.
8. The generated and downloaded file contains all 500 coupons.
9. Choose "Export to Excel XML" and hit the "Export" button.
10. The generated and downloaded file only contains as much items, as choosen in the items per page selector. In the above mentioned example that would be 20.

Questions or comments

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @rogerdz. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

:information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[rogerdz]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

@magento run Functional Tests B2B

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

@magento run Functional Tests B2B

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

:heavy_check_mark: QA Passed

Preconditions: Install fresh Magento 2.4-develop

Manual testing scenario:

1. Create a salesrule of type "Specific Coupon" and check "Use auto generation"
2. Hit "Save and Continue Edit"
3. Head to "Manage Coupon Codes" Tab and generate e.g. 500 Coupons
4. Hit generate and wait for completion
5. Go to generated coupon code list and hit "Mass actions" -> "Select all"
6. All coupons (500) should now be shown as selected.
7. Choose "Export to CSV" and hit the "Export" button.
8. The generated and downloaded file contains all 500 coupons.
9. Choose "Export to Excel XML" and hit the "Export" button.
10. The generated and downloaded file only contains as much items, as choosen in the items per page selector. In the above mentioned example that would be 20.

Before: :heavy_multiplication_x: All coupons were not getting inserted in the XML file

After: :heavy_check_mark: Now working fine.

Additionally tested: Tested for more number of coupon codes for XML as well as for CSV file.

PR is working fine,hence , moving to merge in progress.

Thanks

[engcom-Lima]

Looking like bot has moved this ticket accidently from Merge In progress to Ready for testing. Hence, moving back to merge in progress.