magento/magento2#32679: setup:upgrade --dry-run does not work as expected by other dry-run-commands in Linux-environment

[4ctobias]

• Switched --dry-run-Parameter to VALUE_NONE in UpgradeCommand.php
• Switched --dry-run-Parameter to VALUE_NONE in InstallCommand.php

Description (*)

setup:upgrade and setup:install does not require a value of true when using the --dry-run-parameter. This is now the same beaviour for a dry run as in other Linux-Tools (eg. rsync). As before this fix using --dry-run did not start a dry run for the command, the usage of --dry-run=true was required.

Fixed Issues (if relevant)

1. Fixes magento/magento2#32679

Manual testing scenarios (*)

1. Change a module version
2. Run setup:upgrade --dry-run
3. The module version should not be upgraded in the setup_module-table

[m2-assistant[bot]]

Hi @4ctobias. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant[bot]]

Hi @4ctobias, thank you for your contribution! Please, complete Contribution Survey, it will take less than a minute. Your feedback will help us to improve contribution process.

[ihor-sviziev]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review. ENGCOM-9140 has been created to process this Pull Request

[magento-engcom-team]

Hi @Den4ik, thank you for the review. ENGCOM-9140 has been created to process this Pull Request

[engcom-Dash]

Hello @4ctobias,

Thanks for the collaboration & contribution!

✔️ QA Passed Preconditions:

Install fresh Magento 2.4-develop Steps to reproduce

• Create a module with schema patch.
• Run bin/magento setup:upgrade --dry-run

Before: ✖️ DB schema is being changed. After: ✔️ DB schema should not be changed

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Unit Tests, Static Tests, Integration Tests, Functional Tests CE, Functional Tests B2B

[engcom-Dash]

@magento run Static Tests, Integration Tests, Functional Tests B2B

[engcom-Dash]

The functional B2B test failures are different with a known issue in the most recent two successive builds. Additionally, the static test and Integration Tests failure are a known issue; therefore, I am moving it to Merge in Progress.

Functional Tests B2B Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/33332/3073062905aea28e955ef7361b882fdb/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/33a6fc63d80a2dc6/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/33332/845319c70a7c4f7dca47ffa340c9b10f/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/19e97d5929846bad/