magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Updated Db.php and Dbp.php

Open manavluhar opened this issue 4 years ago • 30 comments

Description (*)

Changed Exception message from Wrong "$connection" parametr to Wrong "$connection" parameter as parameter word is more meaning full compare to parametr

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#38340: Updated Db.php and Dbp.php

manavluhar avatar Jun 08 '21 15:06 manavluhar

Hi @manavluhar. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Jun 08 '21 15:06 m2-assistant[bot]

@magento run all tests

manavluhar avatar Jun 08 '21 15:06 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE, Unit Tests

ihor-sviziev avatar Jul 01 '21 14:07 ihor-sviziev

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Hi @ihor-sviziev, thank you for the review. ENGCOM-9138 has been created to process this Pull Request

magento-engcom-team avatar Jul 01 '21 14:07 magento-engcom-team

@magento run all tests

manavluhar avatar Apr 06 '22 08:04 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

manavluhar avatar Apr 12 '22 19:04 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

manavluhar avatar Apr 13 '22 19:04 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

manavluhar avatar Apr 13 '22 22:04 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Static Tests, WebAPI Tests, Functional Tests EE, Functional Tests CE

manavluhar avatar Apr 14 '22 05:04 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

manavluhar avatar May 13 '22 09:05 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

manavluhar avatar May 16 '22 06:05 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

manavluhar avatar May 16 '22 16:05 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

manavluhar avatar Feb 02 '23 11:02 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

manavluhar avatar Feb 23 '23 11:02 manavluhar

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

engcom-Delta avatar Jan 09 '24 15:01 engcom-Delta

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento create issue

engcom-Delta avatar Jan 09 '24 15:01 engcom-Delta

:heavy_check_mark: QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Go to paths lib/internal/Magento/Framework/Data/Tree/Db.php Go to lib/internal/Magento/Framework/Data/Tree/Dbb.php
  2. Verify Exception message Wrong "$connection" parametr
  3. Verify Exception message should be updated from Wrong "$connection" parametr to Wrong "$connection" parameter

Before: :heavy_multiplication_x: 

Screenshot 2024-01-09 at 8 44 23 PM Screenshot 2024-01-09 at 8 45 17 PM

After: :heavy_check_mark:  

Screenshot 2024-01-09 at 10 23 41 PM Screenshot 2024-01-09 at 10 24 24 PM

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Delta avatar Jan 09 '24 17:01 engcom-Delta