magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] [View] Removed extra space in link and script tag

Open m2-assistant[bot] opened this issue 4 years ago • 4 comments
trafficstars

This issue is automatically created based on existing pull request: magento/magento2#32919: [View] Removed extra space in link and script tag


Description (*)

This PR helps to change extra spaces into single space in <link> and <script> tag.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. ./vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist lib/internal/Magento/Framework/View/Test/Unit/Page/Config/RendererTest.php
  2. Open the store and see <link> and <script> tag using view source code.
  3. <link> and <script> should be without double spaces between attributes.

Actual Result: w_extraspace

Excepted Result: wo_extraspace

Questions or comments

Please let me your suggestions if any

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Apr 30 '21 19:04 m2-assistant[bot]

Hi @krishprakash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar May 03 '21 10:05 m2-assistant[bot]

:white_check_mark: Confirmed by @krishprakash Thank you for verifying the issue. Based on the provided information internal tickets MC-42156 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento-engcom-team avatar May 03 '21 10:05 magento-engcom-team

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12002 is successfully created for this GitHub issue.

github-jira-sync-bot avatar May 24 '24 07:05 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar May 24 '24 07:05 m2-assistant[bot]