[View] Removed extra space in link and script tag

[srsathish92]

Description (*)

This PR helps to change extra spaces into single space in <link> and <script> tag.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

1. ./vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist lib/internal/Magento/Framework/View/Test/Unit/Page/Config/RendererTest.php
2. Open the store and see <link> and <script> tag using view source code.
3. <link> and <script> should be without double spaces between attributes.

Actual Result:

Excepted Result:

Questions or comments

Please let me your suggestions if any

Contribution checklist (*)

• [x] Pull request has a meaningful description of its purpose
• [x] All commits are accompanied by meaningful commit messages
• [x] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#32920: [View] Removed extra space in link and script tag

[m2-assistant[bot]]

Hi @srsathish92. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[srsathish92]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[srsathish92]

@magento create issue

[Den4ik]

@magento run Functional Tests EE, Functional Tests B2B

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[srsathish92]

@magento run Functional Tests B2B

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[srsathish92]

@magento run Functional Tests B2B

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-engcom-team]

Hi @Den4ik, thank you for the review. ENGCOM-9060 has been created to process this Pull Request :eight_spoked_asterisk: @Den4ik, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

Hi @ptylek, thank you for the review. ENGCOM-9060 has been created to process this Pull Request

[hostep]

I don't know if there are valid cases for having multiple spaces inside an html attribute value, but this PR would break that I think. The preg_replace solution is maybe not the best option here?

<script type="text/javascript" attr="value  with     multiple spaces" src="url"></script>

would turn into:
<script type="text/javascript" attr="value with multiple spaces" src="url"></script>

Again: very unsure if people have actual valid use cases for attribute values with consecutive spaces.

Just leaving a comment here in case this hasn't crossed anybody's mind yet.

[Den4ik]

I'm not sure that usage of multiple spaces in attributes is a good practice and useful use case

[engcom-Delta]

Hi @srsathish92 , Thanks for your contribution.Please resolve the conflicts to move ahead on this PR

[srsathish92]

@magento run all tests

[engcom-November]

@magento run all tests

[engcom-November]

This is a code-quality pr, no manual testing is required.

As the builds are failing moving this to Extended testing.

[engcom-November]

@magento run all tests

[engcom-November]

@magento run Static Tests, Integration Tests, Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

[engcom-November]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

[engcom-November]

For functional tests, repeating failures are known issues and are flaky.

Functional Tests B2B: 1st Run:

2nd Run:

Known issues: ACQE-6523 - AdminReorderWithCatalogPriceRuleDiscountTest

Functional Tests CE: 1st Run:

2nd Run:

Known issues: ACQE-6590 - AdminCheckConfigurationForPayPalExpressCheckoutInUnitesStatesTest

Functional Tests EE: 1st Run:

2nd Run:

Known issues: ACQE-6523 - AdminReorderWithCatalogPriceRuleDiscountTest ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest

[engcom-November]

WebAPI repeating failure is known issue and is flaky.

1st Run:

2nd Run:

Known issue: ACP2E-3082 - testSendNegotiableQuoteCannotResend

Hence moving this to Merge in Progress