magento2
magento2 copied to clipboard
[Issue] Add EventPrefix and EventObject to checkout agreement model
This issue is automatically created based on existing pull request: magento/magento2#32451: Add EventPrefix and EventObject to checkout agreement model
Description (*)
Added EvenPrefix and EventObject for checkout agreement model to trigger the event with event prefix.
Related Pull Requests
Fixed Issues (if relevant)
- ...
Manual testing scenarios (*)
- Add observer for any of the following,
- sales_agreement_load_before
- sales_agreement_load_after
- sales_agreement_save_commit_after
- sales_agreement_save_before
- sales_agreement_save_after
- sales_agreement_delete_before
- sales_agreement_delete_after
- sales_agreement_delete_commit_after
- sales_agreement_clear
- Check observer code is executed and also received 'agreement' in event data
Questions or comments
Contribution checklist (*)
- [ ] Pull request has a meaningful description of its purpose
- [ ] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] All automated tests passed successfully (all builds are green)
Test
Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
- [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
- [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
- [ ] 3. Add
Area: XXXXXlabel to the ticket, indicating the functional areas it may be related to. - [ ] 4. Verify that the issue is reproducible on
2.4-developbranchDetails
- Add the comment@magento give me 2.4-develop instanceto deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-developbranch, please, add the labelReproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here! - [ ] 5. Add label
Issue: Confirmedonce verification is complete. - [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
Hello @yogesh-valiya,
Thanks for the report and collaboration!
We need some more information on this issue as follows:
- Please describe the issue you are trying to fix in its related PR.
- Any use case you have adding EventPrefix and EventObject
- Details steps to reproduce this issue.
Thanks
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13252 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.