magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Add EventPrefix and EventObject to checkout agreement model

Open m2-assistant[bot] opened this issue 4 years ago • 5 comments

This issue is automatically created based on existing pull request: magento/magento2#32451: Add EventPrefix and EventObject to checkout agreement model


Description (*)

Added EvenPrefix and EventObject for checkout agreement model to trigger the event with event prefix.

Related Pull Requests

Fixed Issues (if relevant)

  1. ...

Manual testing scenarios (*)

  1. Add observer for any of the following,
    • sales_agreement_load_before
    • sales_agreement_load_after
    • sales_agreement_save_commit_after
    • sales_agreement_save_before
    • sales_agreement_save_after
    • sales_agreement_delete_before
    • sales_agreement_delete_after
    • sales_agreement_delete_commit_after
    • sales_agreement_clear
  2. Check observer code is executed and also received 'agreement' in event data

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Mar 16 '21 16:03 m2-assistant[bot]

Test

yogesh-valiya avatar Mar 17 '23 04:03 yogesh-valiya

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Jul 12 '24 08:07 m2-assistant[bot]

Hello @yogesh-valiya,

Thanks for the report and collaboration!

We need some more information on this issue as follows:

  1. Please describe the issue you are trying to fix in its related PR.
  2. Any use case you have adding EventPrefix and EventObject
  3. Details steps to reproduce this issue.

Thanks

engcom-Hotel avatar Jul 12 '24 08:07 engcom-Hotel

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13252 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Oct 17 '24 06:10 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Oct 17 '24 06:10 m2-assistant[bot]