Add EventPrefix and EventObject to checkout agreement model

[yogesh-valiya]

Description (*)

Added EvenPrefix and EventObject for checkout agreement model to trigger the event with event prefix.

Related Pull Requests

Fixed Issues (if relevant)

1. ...

Manual testing scenarios (*)

1. Add observer for any of the following,
   • checkout_agreement_load_before
   • checkout_agreement_load_after
   • checkout_agreement_save_commit_after
   • checkout_agreement_save_before
   • checkout_agreement_save_after
   • checkout_agreement_delete_before
   • checkout_agreement_delete_after
   • checkout_agreement_delete_commit_after
   • checkout_agreement_clear
2. Check observer code is executed and also received 'agreement' in event data

Questions or comments

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#32510: Add EventPrefix and EventObject to checkout agreement model

[m2-assistant[bot]]

Hi @yvaliya. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[yogesh-valiya]

@magento run all tests

[yogesh-valiya]

@magento run Functional Tests CE

[yogesh-valiya]

@magento run all tests

[gabrieldagama]

@magento create issue

[magento-engcom-team]

Hi @edenduong, thank you for the review. ENGCOM-8933 has been created to process this Pull Request

[yogesh-valiya]

@magento-engcom-team Would it be possible to receive an update regarding the status of this PR and any reasons why it has not been merged yet?

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hi @yogesh-valiya,

Thanks for the collaboration & contribution!

✔️ QA Passed Preconditions:

Install fresh Magento 2.4-develop Steps to reproduce As per the description Before: ✖️

• Event is not triggered.

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

[engcom-Dash]

The Functional CE and B2B test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Functional Tests CE Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32451/da2a67bd00f52bb4819f76b59f1191bd/Functional/allure-report-ce/index.html#categories/a644910ae0cb11e839a98baa21929b76/91c5c8d0cf2b7e4d/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32451/dce2e1dbd145a8b18255832da7fa490a/Functional/allure-report-ce/index.html#categories/6ca9d315ebd9ab54dbe1fb9148ebdc1f/a3ca9306a26d3162/

Functional Tests B2B Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32451/79fe4e8cb60041e4695a70025a8df98a/Functional/allure-report-b2b/index.html#categories/6ca9d315ebd9ab54dbe1fb9148ebdc1f/3813656c7c921805/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32451/2f7c25466171b0e799957346f2466f18/Functional/allure-report-b2b/index.html#categories/fa4393da515eaa6ecde572b60691d27d/afc7de726ea55155/

[engcom-Dash]

@magento run all tests