Refactoring of the code

[ejaz-alam]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#38503: Refactoring of the code

Resolved issues:

1. [x] resolves magento/magento2#39281: Refactoring of the code

[m2-assistant[bot]]

Hi @ejaz-alam. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Functional Tests B2B , Functional Tests CE, WebAPI Tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review. ENGCOM-8880 has been created to process this Pull Request

[engcom-Delta]

@magento create issue

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Manual testing is not required for this change since the functionality remains unchanged; the logic has been simplified without affecting behavior.

Builds are failed, so moving it to Extended Testing.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hello @ejaz-alam,

Thank you so much for your contribution!

I wanted to reach out to let you know that while I was fixing the static failure on your PR, I unfortunately made a mistake by force-pushing my changes. After doing this, I realized I couldn't find your original commit (which is quite strange). I checked the git log and the orphan log but was unable to locate it. As a result, I reset the branch and pushed a new commit.

I sincerely apologize for this oversight and any inconvenience it may have caused. Thank you for your understanding!

Thanks again!

[engcom-Dash]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Static Tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE

[engcom-Charlie]

@magento run Functional Tests CE

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Charlie]

The Functional CE failures are not consistent in recent 2 builds. Neither they are part of this PR now failing because of PR changes.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/ee190589dadf37eaef40f52cf7f04d92/Functional/allure-report-ce/index.html#categories

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/2af0531e5f5178efa38593820c635240/Functional/allure-report-ce/index.html#categories

[engcom-Charlie]

The integration failure in recent 2 builds is a known issue.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/134ab72269c8cc040601fcc9a885d496/Integration/console-error-logs.html

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/134ab72269c8cc040601fcc9a885d496/Integration/console-error-logs.html

Known Issue: AC-13584

[engcom-Charlie]

@magento run Functional Tests B2B

[engcom-Charlie]

The Functional B2B failures are not consistent in recent 2 builds. Neither they are part of this PR now failing because of PR changes. Hence moving this PR to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/d786c77b538f930c082e52fc27c19d63/Functional/allure-report-b2b/index.html#categories

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/855a93413af14174d7fdda93ca40057e/Functional/allure-report-b2b/index.html#categories

[engcom-Dash]

Moving this PR to Extended Testing to resolve conflicts

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests CE, Functional Tests B2B, Unit Tests

[engcom-Dash]

The consistent Functional B2B failures are known issue other failures are flaky. Neither they are part of this PR now failing because of PR changes. Hence moving this PR to Merge in Progress.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/52451bbbd5e7d18b9e3666c96f22bb11/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/73921c5984d3cee6bf843e5f351e2d85/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Known Issue: OrderWithMultipleConfigurableProductsAdditionalStockTest https://jira.corp.adobe.com/browse/ACQE-8060

Unit Tests are failing without any error. It is known build issue. https://jira.corp.adobe.com/browse/ACQP-5143