magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Published 20 hours ago • verified publisher icon magento

Remove a duplicated <severity> tag from MFTF test AdminSetUpWatermarkForSwatchImageTest

Open denchev opened this issue 4 years ago • 10 comments

Description (*)

While looking at functional tests provided by Magento I found that one of the tests AdminSetUpWatermarkForSwatchImageTest has two severity tags with the same value = MAJOR. I think only one of them is needed.

Related Pull Requests

I cannot find which pull request added the second one but the commit is https://github.com/magento/magento2/commit/bba6a438c71045eef0083bfa3374065b26d9485d

The original commit that introduced the test and the first severity tag is https://github.com/magento/magento2/commit/9bea49f2e5e1b41c18aa4bf0b12510e083a5f1e4

Fixed Issues (if relevant)

No issue is created for this ticket.

Manual testing scenarios (*)

No manual tests are required. This is code refactoring.

Questions or comments

No questions or comments at this point.

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [x] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#38504: Remove a duplicated tag from MFTF test AdminSetUpWatermarkForSwatchImageTest

denchev avatar Jan 27 '21 14:01 denchev

Hi @denchev. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Jan 27 '21 14:01 m2-assistant[bot]

Hi @ihor-sviziev, thank you for the review. ENGCOM-8708 has been created to process this Pull Request

magento-engcom-team avatar Jan 27 '21 15:01 magento-engcom-team

@magento run all tests

denchev avatar Jan 27 '21 19:01 denchev

@gabrieldagama @sidolov, can we quickly merge this PR? it fixes duplicated XML fields in MFTF tests. The risk of this PR is shallow.

ihor-sviziev avatar Jan 29 '21 13:01 ihor-sviziev

Hi @ihor-sviziev! The fix does not affect test execution flow, so, the delivery may be postponed for a while since we still have a lot of PRs in high priority backlog.

sidolov avatar Jan 29 '21 14:01 sidolov

@magento create issue

engcom-Delta avatar Mar 08 '24 12:03 engcom-Delta

Manual testing is not required since it removes duplicate variables from the file.

Builds are failed, so moving it to Extended Testing.

engcom-Dash avatar Oct 17 '24 11:10 engcom-Dash

@magento run all tests

engcom-Dash avatar Oct 17 '24 11:10 engcom-Dash

@magento run Functional Tests B2B

engcom-Dash avatar Oct 17 '24 14:10 engcom-Dash

The Functional B2B test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Functional Tests B2B Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31862/a88c2be778a7f7fc408027aa62ded497/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741 image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31862/3d20cae159b7173af956c63361647061/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/5a833956448d3705/ image

engcom-Dash avatar Oct 18 '24 09:10 engcom-Dash

@magento run all tests

engcom-Dash avatar Aug 26 '25 12:08 engcom-Dash

Moving this PR to Extended Testing to fix the static check failure.

engcom-Dash avatar Aug 28 '25 06:08 engcom-Dash

@magento run all tests

engcom-Dash avatar Aug 28 '25 07:08 engcom-Dash

@magento run all tests

engcom-Dash avatar Aug 28 '25 10:08 engcom-Dash

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

engcom-Dash avatar Aug 28 '25 12:08 engcom-Dash

The consistent failures in Functional B2B are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes.

Build 1 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31862/a13a99b6440bce5d44f046a62c706380/Functional/allure-report-b2b/index.html#categories/08b12368a80c7bb36e8ca83ae2634316/8198a655044d629d/ image

Build 2 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31862/71d1df3c980b74a1285887ba7d7a0634/Functional/allure-report-b2b/index.html#categories/494aa5610e07373f0a3ae73eacf3dae2/22c0d88a37abd2cb/

image Known Issue

AdminChangeContentOfWysiwygEditorForDisabledByDefaultScheduleTest ACQE-8336 StorefrontCreatePurchaseOrderFromNegotiableQuoteTest ACQE-8645 AssignCustomOrderStatusNotVisibleOnStorefrontTest ACQE-8490 ViewportSwitcherMobileHTMLThroughBlockContentTypeTest ACQE-8608 BlockRenderHTMLThroughBlockContentTypeTest ACQE-8635 AdminDeleteTheUpdateTest ACQE-8502 AdminStagingDashboardProvideAbilityToViewEditForUpdatesWithCartPriceRuleTest ACQE-8610

The consistent failures in Functional CE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes. Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31862/290f70fbfdd49c15eb79da90e5437e78/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d image Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31862/3f1a72b790b2e8a76beccf7eb0f05d29/Functional/allure-report-ce/index.html#categories/27a3f18c53d213aeff4eef4a10f923a2/aa219de986b83409/ image Known issue: StorefrontEnsureThatAccordionAnchorIsVisibleOnViewportOnceClickedTest ACQE-8383 ViewportSwitcherMobileHTMLThroughBlockContentTypeTest ACQE-8608 BlockRenderHTMLThroughBlockContentTypeTest ACQE-8635 StorefrontDeleteSimpleAndVirtualProductFromMiniShoppingCartTest ACQE-8560

The consistent failures in Functional EE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes. Build1 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31862/157536b0069c189f00f3c250251320e6/Functional/allure-report-ee/index.html#categories/494aa5610e07373f0a3ae73eacf3dae2/728ed9e4dc23fe65/ image

Build2 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31862/c5db81829b5e8684d14fe0241bba3a2a/Functional/allure-report-ee/index.html image

Known Issue AssignCustomOrderStatusNotVisibleOnStorefrontTest ACQE-8490 ViewportSwitcherMobileHTMLThroughBlockContentTypeTest ACQE-8608 BlockRenderHTMLThroughBlockContentTypeTest ACQE-8635 AdminStagingDashboardProvideAbilityToViewEditForUpdatesWithCartPriceRuleTest ACQE-8610 AdminCopySingleUpdateToAnotherUpdateTest ACQE-8401

Hence, Moving this PR to Merge In Progress

engcom-Dash avatar Aug 29 '25 09:08 engcom-Dash