Improve exception handling

[ihor-sviziev]

Description (*)

When the basic exception appears - we're having mixed HTML and plain text. This PR fixes this.

Before:

❌ <pre> tags are rendered

After:

✔ <pre> tags are not rendered

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#38499: Improve exception handling

[m2-assistant[bot]]

Hi @ihor-sviziev. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Unit Tests

[ihor-sviziev]

@magento run Unit Tests

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@Stepa4man pls review, tests are passing now

[magento-engcom-team]

Hi @Stepa4man, thank you for the review. ENGCOM-8611 has been created to process this Pull Request

[magento-engcom-team]

Hi @Den4ik, thank you for the review. ENGCOM-8611 has been created to process this Pull Request

[hostep]

Great to see progress in a PR with prio P4, let's hope other PR's with low prio that have been open since ages will now also finally get processed ... 😉

[engcom-Delta]

@magento create issue

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Manual testing is not required since it changes the header from plain text to HTML for better visibility of exceptions.

Build are failed, so moving it to Extended Testing.

[engcom-Dash]

@magento run Functional Tests EE, Functional Tests B2B

[engcom-Dash]

The Functional B2B test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31598/210e366ab0feebdceda8301b291d4231/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/919ddc55455fec31/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31598/1bb0bd64d27bcd6e278f02a4a100d27c/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

[engcom-Dash]

Hello @ihor-sviziev,

Thanks for your contributions!

Moving this PR to on hold since it’s a feature request and we need PO approval for it. Once we get approval, we will proceed accordingly.

Thanks.

[engcom-Dash]

Hello @ihor-sviziev,

We have received the go-ahead on this PR from the PO. We are moving it to extended testing for now to analyze the build results with the latest code.

Thanks.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

We have a green build so moving it to "Merge in Progress".