magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Correct plural string

Open Amadeco opened this issue 4 years ago • 8 comments

Description (*)

Just found it today, a mistyping somewhere :-)

Display correct plural strings under condition

Resolved issues:

  1. [x] resolves magento/magento2#31215: Correct plural string

Amadeco avatar Dec 08 '20 14:12 Amadeco

Hi @mageho. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Dec 08 '20 14:12 m2-assistant[bot]

@magento create issue

sidolov avatar Dec 08 '20 19:12 sidolov

@magento run all tests

ihor-sviziev avatar Jan 21 '21 08:01 ihor-sviziev

Hi @mageho, thank you for your contribution! Please, complete Contribution Survey, it will take less than a minute. Your feedback will help us to improve contribution process.

m2-assistant[bot] avatar Jan 23 '21 17:01 m2-assistant[bot]

Hi @mageho. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

m2-assistant[bot] avatar Jan 23 '21 17:01 m2-assistant[bot]

Hi @mageho, Could you sign Adobe CLA? Unfortunately, without it, we can't accept any PR.

Done @ihor-sviziev

Amadeco avatar Jan 23 '21 17:01 Amadeco

@magento run Functional Tests CE, Functional Tests B2B, Static Tests

ihor-sviziev avatar Jan 23 '21 21:01 ihor-sviziev

Hi @ihor-sviziev, thank you for the review. ENGCOM-8700 has been created to process this Pull Request

magento-engcom-team avatar Jan 24 '21 13:01 magento-engcom-team

@magento run all tests

engcom-Dash avatar Oct 18 '24 09:10 engcom-Dash

Closing this PR since no file changes are visible after updating the branch.

engcom-Dash avatar Oct 18 '24 14:10 engcom-Dash