Remove duplicated variables from one of less files

[lumnn]

Description (*)

PR removes 2 duplicated values from one of the less files.

Questions or comments

The removed code can also be found on lines 70, 71

Contribution checklist (*)

• [X] Pull request has a meaningful description of its purpose
• [X] All commits are accompanied by meaningful commit messages
• [X] All new or changed code is covered with unit/integration tests (if applicable)
• [X] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#31154: Remove duplicated variables from one of less files

[m2-assistant[bot]]

Hi @lumnn. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sidolov]

@magento create issue

[ihor-sviziev]

@magento run all tests

[mrtuvn]

you have hawk eyes nice catch!

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review. ENGCOM-8512 has been created to process this Pull Request

[ihor-sviziev]

@magento run Functional Tests B2B

[magento-engcom-team]

Hi @ptylek, thank you for the review. ENGCOM-8512 has been created to process this Pull Request

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Manual testing is not required since it removes duplicate variables from the file.

Builds are failed, so moving it to Extended Testing.

[engcom-Dash]

Got the green build so moving it to merge in progress.

[hostep]

Before this gets merged, the first variable is indeed a duplicate definition, but the second one is not, unless I'm missing something, these don't match 100%:

line 71: @_pager-action-text-decoration-hover: @pager-action__hover__text-decoration,

vs

line 94: @_pager-action-text-decoration-hover: @pager-action__text-decoration,  

The proposal in this PR is to remove the second one, which should cause a change in behavior, right? So I don't understand why we shouldn't test this change?

Manual testing is not required since it removes duplicate variables from the file.

[engcom-Dash]

Before this gets merged, the first variable is indeed a duplicate definition, but the second one is not, unless I'm missing something, these don't match 100%:

line 71: @_pager-action-text-decoration-hover: @pager-action__hover__text-decoration,

vs

line 94: @_pager-action-text-decoration-hover: @pager-action__text-decoration,  

The proposal in this PR is to remove the second one, which should cause a change in behavior, right? So I don't understand why we shouldn't test this change?

Manual testing is not required since it removes duplicate variables from the file.

Thanks, @hostep. I reviewed the codebase earlier but it seems I overlooked the line 94. I've now reverted the changes on line 94.

I’m moving it to Extended Testing again since I reverted the changes on line 94.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests EE, Functional Tests B2B

[engcom-Dash]

Got the green build so moving it to merge in progress.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Functional Build is failing for CE, EE, and B2B since moving this for Extended Testing

[engcom-Dash]

@magento run all tests

[engcom-Dash]

The consistent failures in Functional B2B are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes.

Build 1 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31150/4715191ec7a921bb5a5cd34136aac57a/Functional/allure-report-b2b/index.html#categories Build 2 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31150/973ed5e57d8d3a81bf9428021642483d/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741 Known Issue AdminVerifyBehaviorOfDefaultStatusForProcessingStateTest ACQE-8689 StorefrontCreatePurchaseOrderFromNegotiableQuoteTest ACQE-8645

The consistent failures in Functional EE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes.

Build 1 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31150/eb3e502f59899810967f253649e55a9e/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d Build 2 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31150/fa5f3f75b332b7d20da05d5b0196a558/Functional/allure-report-ee/index.html#categories/bdbf199525818fae7a8651db9eafe741 Known Issue AdminVerifyBehaviorOfDefaultStatusForProcessingStateTest ACQE-8689

The consistent failures in Functional CE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes. Build 1 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31150/c63f4048a19ff39f400cb0af40b25839/Functional/allure-report-ce/index.html Build 2 https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31150/525e9e94c3ddd44fbe50235a6263b54e/Functional/allure-report-ce/index.html#categories/bdbf199525818fae7a8651db9eafe741 Known Issue AdminVerifyBehaviorOfDefaultStatusForProcessingStateTest ACQE-8689

Hence, Moving this PR to Merge In Progress