magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Banktransfer payment method on multistore showing wrong title (of default store view) on order overview grid

Open plastikschnitzer opened this issue 5 years ago • 24 comments

Preconditions (*)

  1. Magento 2.4-develop
  2. Multistore with different websites (Main Website and New Website) image
  3. Set Title and Instructions of Bank Transfer Payment for each store view image image

Steps to reproduce (*)

  1. Place order in New Website with payment method banktransfer
  2. Go to admin
  3. Go to Sales->Orders
  4. Add Payment Method column

Expected result (*)

  1. The correct payment title and instructions should show from the correct website.

Actual result (*)

  1. Payment title and instructions is displayed from default store view settings image

Additional info: Same was done for Shipping Method and it shows correct value for each store view

Issue seems to be similar to #15420 and applies also to the checkmo payment method.

plastikschnitzer avatar Aug 16 '20 10:08 plastikschnitzer

Hi @plastikschnitzer. Thank you for your report. To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Aug 16 '20 10:08 m2-assistant[bot]

@magento give me 2.4-develop instance

plastikschnitzer avatar Aug 16 '20 10:08 plastikschnitzer

Hi @plastikschnitzer. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team avatar Aug 16 '20 10:08 magento-engcom-team

Hi @plastikschnitzer, here is your Magento instance. Admin access: https://i-29568-2-4-develop.instances.magento-community.engineering/admin_3623 Login: e661b795 Password: 8689fb80582e Instance will be terminated in up to 3 hours.

magento-engcom-team avatar Aug 16 '20 10:08 magento-engcom-team

Thank you @magento but we have a little problem with the automatic testing instances: They are single stores only. I can create multiple store views inside them but this does not help. I need to create and test in different multisite websites, and as I cannot access your shops index.php, I think I cannot build a proper multisite for testing. Please correct me if I am wrong and advise how to build a proper multisite testing instance with multiple websites.

plastikschnitzer avatar Aug 16 '20 10:08 plastikschnitzer

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 17 '20 10:08 m2-assistant[bot]

Hi @plastikschnitzer thank you for your report.

Issue is not reproducible by steps you described on clean 2.4-develop. Please, see comment

Actually you could create multisite websites on test instance, set Stores->Configuration->General->Web->Url Options->Add Store Code to Urls=Yes and navigate to each website by adding store code to base url, e.g., http://example.com/your_store_code

engcom-Delta avatar Aug 17 '20 10:08 engcom-Delta

@engcom-Delta thank you very much! I will try again with the Multistore setup you described. Also interesting to see that I am not the only one who experienced the issue.

@magento give me 2.4-develop instance

plastikschnitzer avatar Aug 17 '20 17:08 plastikschnitzer

Hi @plastikschnitzer. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team avatar Aug 17 '20 17:08 magento-engcom-team

Hi @plastikschnitzer, here is your Magento instance. Admin access: https://i-29568-2-4-develop.instances.magento-community.engineering/admin_223b Login: 0e48a2b7 Password: edfe3e30c949 Instance will be terminated in up to 3 hours.

magento-engcom-team avatar Aug 17 '20 17:08 magento-engcom-team

Hello @engcom-Delta I tested the issue again and I can confirm it is almost fixed in Magento 2.4-develop. Only one small detail of the bug remains and I could rebuild it here in your 2.4-develop instance AND in my Magento 2.3.5-p1 where I just copied over the app/code/Magento/OfflinePayments folder from the 2.4-dev version (not sure if this is best practice, but at least it did not break the shop and its working better than before – maybe little hint for those who experience the same bug, please test it carefully!).

In Magento Admin on the order list page, I can display the payment method. If I do so, I get the title of the default store view, not the title of the payment method from website-2 where I placed the order in (see 2 screenshots.):

Screenshot_2020-08-17 #2000000001 Orders Operations Sales Magento Admin

Screenshot_2020-08-17 Orders Operations Sales Magento Admin

So my initial bugreport title is wrong, it must read something like "showing always default store view settings in order overview grid". All other places (order emails, magento admin order detail pages) are fixed.

I did not test the other offline payment methods!

plastikschnitzer avatar Aug 17 '20 18:08 plastikschnitzer

:white_check_mark: Confirmed by @engcom-Delta Thank you for verifying the issue. Based on the provided information internal tickets MC-37277 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento-engcom-team avatar Sep 01 '20 12:09 magento-engcom-team

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

stale[bot] avatar Jan 29 '21 00:01 stale[bot]

still relevant.

plastikschnitzer avatar Feb 05 '21 08:02 plastikschnitzer

@magento I am working on it

hardik028 avatar Mar 28 '21 07:03 hardik028

Hi @hardik028! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

m2-assistant[bot] avatar Mar 28 '21 07:03 m2-assistant[bot]

@magento add to contributors team

hardik028 avatar Mar 28 '21 07:03 hardik028

Hi @hardik028! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

m2-assistant[bot] avatar Mar 28 '21 07:03 m2-assistant[bot]

@magento I am working on it

hardik028 avatar Mar 28 '21 07:03 hardik028

Did anyone get the solution?

amitmaurya191 avatar Jun 05 '21 14:06 amitmaurya191

2022-02-10 13_05_34-C__Users_Priit_AppData_Local_Temp_scp32474_var_www_notebooks-live_web_vendor_mag

I had the same issue and discovered that Magento has sales_order_payment_save_before event listener declared in the offline-payments plugin. On checkmo payments I added 2 lines into the BeforePaymentsSaveObserver and the issue is fixed.

Probably same thing needs to be done with the Banktransfer payment. Those 2 lines just tell the $methodInstance what store ID it should use and now all good.

matish avatar Feb 10 '22 14:02 matish

Hi @plastikschnitzer,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot 2024-06-28 at 10 47 00 Screenshot 2024-06-28 at 10 49 17

In the order details it is working fine while order grid has the issue showing default payment information.

Hence Confirming the issue.

Thanks.

engcom-Bravo avatar Jun 28 '24 05:06 engcom-Bravo

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12308 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Jun 28 '24 05:06 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Jun 28 '24 05:06 m2-assistant[bot]