magento2-phpstorm-plugin icon indicating copy to clipboard operation
magento2-phpstorm-plugin copied to clipboard

Compare Overriden Template With Original Does Not Work With Composer Path Repositories

Open sprankhub opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe.

I absolutely love the new feature from #1032, which adds the possibility to compare an overridden template with the original one. Thanks a lot for implementing this, @bohdan-harniuk! Unfortunately, it does not work with themes added via Composer, though. Please read through my previous explanation why that makes sense. So in general, this should also work with themes under vendor and themes under custom directories if these directories are used as local Composer path repositories.

Describe the solution you'd like (*)

I would like that the feature also supports themes added via Composer.

Describe alternatives you've considered

None.

Additional context

A similar issue has been fixed in #64.

sprankhub avatar Apr 05 '22 12:04 sprankhub

Hi @sprankhub. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


m2-assistant[bot] avatar Apr 05 '22 12:04 m2-assistant[bot]

Hello, @sprankhub!

Thank you for your report! We will try to implement your suggestion in the next feature release.

Also, about implementing something in general, it is not possible to make everything in one shot, it is iterative process. If you want, you can also join us and help with the plugin development. It is very interesting and useful project to contribute in.

Regards,

bohdan-harniuk avatar Apr 18 '22 11:04 bohdan-harniuk