magento2-page-builder
magento2-page-builder copied to clipboard
When added a new empty row to product description it gives a Uncaught ReferenceError: jarallax is not defined
Preconditions (*)
- Any version of page-builder installed
Steps to reproduce (*)
- Go to a product edit page on admin 2.Edit the description field with Page Builder
- Add a new empty row
- Save the product
- After the page is reloaded, try to edit with Page Builder and remove the empty row
- An error is triggered on console with
Uncaught ReferenceError: jarallax is not defined - Save the product (after the row is removed)
- Then the page is reloaded and the empty row continues appearing there and it's not possible to remove it
Expected result (*)
- The row is removed with no errors after the product is saved
Actual result (*)
- The empty row continues showing up even after his removal
Hi @andrewdaluz. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel.
It looks like the issue is related to the misspelling of the jarallax variable that should be _jarallax:
_proto.destroy = function destroy() {
_previewCollection2.prototype.destroy.call(this);
if (this.element) {
jarallax(this.element, "destroy");
}
}
to
_proto.destroy = function destroy() {
_previewCollection2.prototype.destroy.call(this);
if (this.element) {
_jarallax(this.element, "destroy");
}
}
Hello @andrewdaluz ,
Thank you for your report and collaboration.
We attempted to reproduce the issue in version 2.4 develop but were unable to do so. Attached the screen recording for your references.
Steps to Reproduce:
- Login to magento admin
- Go to a product edit page on admin
- Edit the description field with Page Builder
- Add a new empty row
- Save the product
- After the page is reloaded, try to edit with Page Builder and remove the empty row
- Save the product (after the row is removed)
We followed these steps and did not encounter any errors. Could you please recheck the issue in the latest version? Alternatively, let us know if we missed any steps while reproducing the issue.
Therefore, we are marking this ticket as "Needs Update."
Thank You!
Interesting. Might that be a Firefox or Chrome tests? The issue is on https://github.com/magento/magento2-page-builder/blob/develop/app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/row/preview.js You can see that the variable in the function (_jarallax) while in the scope of the function it's been called as jarallax() and not the _jarallax() method.
Hello @andrewdaluz ,
We attempt to reproduce this issue in my latest 2.4 develop instances but we are unable to reproduce it and we verified in chrome and Firebox but the issue is not reproducible.
Steps to Reproduce:
- Login to magento admin
- Go to a product edit page on admin
- Edit the description field with Page Builder
- Add a new empty row
- Save the product
- After the page is reloaded, try to edit with Page Builder and remove the empty row
- Save the product (after the row is removed)
We followed these steps and did not encounter any errors. Could you please recheck the issue in the latest version? Alternatively, let us know if we missed any steps while reproducing the issue.
Therefore, we are marking this ticket as "Needs Update."
Thank You!
Hello,
This issue is being closed since it has not been updated in a long time. Please feel free to reopen or raise a new ticket if the issue still exists.
Thank You!