magento2-page-builder icon indicating copy to clipboard operation
magento2-page-builder copied to clipboard

Min height converter throw error when new style is added to mobile breakpoint

Open syno-jde opened this issue 1 year ago • 1 comments

Hello!

I want to have the possibility to define specific margin and padding in desktop and mobile like min-height but it's throw an error in the back-office.

Step to reproduce

  1. Add mobile breakpoint to existing margins_and_padding field (Vendor/PageBuilder/view/adminhtml/ui_component/pagebuilder_base_form.xml):
<?xml version="1.0" encoding="UTF-8"?>
<form xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Ui:etc/ui_configuration.xsd">
    <fieldset name="advanced">
        <field name="margins_and_padding" formElement="input">
            <argument name="data" xsi:type="array">
                <item name="config" xsi:type="array">
                    <item name="default" xsi:type="null" />
                    <item name="breakpoints" xsi:type="array">
                        <item name="mobile" xsi:type="boolean">true</item>
                    </item>
                </item>
            </argument>
        </field>
    </fieldset>
</form>
  1. Add padding or margin in mobile view in Banner block form. Save. Error is throwed in the console.

I fixed it in my fork https://github.com/magento/magento2-page-builder/compare/develop...syno-jde:magento2-page-builder:develop

syno-jde avatar Oct 24 '24 08:10 syno-jde

Hi @syno-jde. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Oct 24 '24 08:10 m2-assistant[bot]

Hello @syno-jde,

Thanks for the report and collaboration!

We are using this platform to log issues related to the core libraries of Pagebuilder. However, after reviewing the description, it appears that the issue may be caused by a custom requirement.

Please let us know if our understanding is incorrect.

Thanks

engcom-Hotel avatar Sep 22 '25 09:09 engcom-Hotel