magento2-page-builder
magento2-page-builder copied to clipboard
fix container width for description inside the catalog product view
Description (*)
When I insert the description of the product I have this problem:
It's not aligned
FIX:

The text should be aligned
Story
Bug
- #801 fix the container for description inserted with page builder inside catalog product view
- #35123 fix the container for description inserted with page builder inside catalog product view
Task
Fixed Issues (if relevant)
- magento/magento2-page-builder#<issue_number>: Issue title
Builds
Related Pull Requests
Manual testing scenarios (*)
- Magento 2.4.3-p1
- Module Page Builder Enabled (Default)
- Design Page - Template Product full width (Default with page builder enabled)
- Enter to the backoffice
- Create a Product and insert a description with page builder inside a row and 1 column
- Save
Questions or comments
Checklist
- [ ] Pull request has a meaningful description of its purpose
- [ ] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@magento run all tests
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@magento run all tests
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@magento run Static Tests, Unit Tests, WebAPI Tests
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@magento run all tests
@magento give me 2.4-develop test instance
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-Bravo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.
@magento give me test instance
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-Bravo, here is your Magento Instance: https://448bc05276c29e181ed3a7033f20317d.instances-prod.magento-community.engineering Admin access: https://448bc05276c29e181ed3a7033f20317d.instances-prod.magento-community.engineering/admin_0b90 Login: 2180a752 Password: a6342b2bd182
@magento run all tests
Hi @PierW,
Thanks for the collaboration & contribution!
:heavy_check_mark: QA Passed
Preconditions:
- Install fresh Magento
2.4-develop
Manual testing scenario:
- Module Page Builder Enabled (Default)
- Design Page - Template Product full width (Default with page builder enabled)
- Enter to the backoffice
- Create a Product and insert a description with page builder inside a row and 1 column
- Save
Before: :heavy_multiplication_x:
After: :heavy_check_mark:
Thanks.
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Performance Acceptance Tests, Static Tests, Unit Tests
@magento run all tests
@magento run Functional Tests CE, Integration Tests, Static Tests, WebAPI Tests
@magento run Static Tests
@magento run all tests
@magento run Functional Tests EE, Integration Tests, WebAPI Tests
@magento run WebAPI Tests
The WebAPI failures on consecutive runs are different, and are flaky.
1st Run
2nd Run
Hence moving this pr for further processing.
@magento run WebAPI Tests
@engcom-Hotel do you think it's better to use shorthand in this case? If so, could you make the following changes? Current code:
padding-left: 15px;
padding-right: 15px;
Proposed change:
padding: 0 15px;
Sure @TuVanDev, Please make the change. We will then proceed with this PR.
Till then moving PR to Changes Requested
Thanks
@magento run all tests
I don't have permission to make the changes. Thanks to @engcom-Hotel for the changes.
Hi @PierW,
Thanks for your Contribution!!.
We have verified the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.
Could you please let us know if we are missing anything here.
Thanks.