magento2-page-builder icon indicating copy to clipboard operation
magento2-page-builder copied to clipboard

fix container width for description inside the catalog product view

Open PierW opened this issue 3 years ago • 29 comments
trafficstars

Description (*)

When I insert the description of the product I have this problem:

Schermata 2022-02-19 alle 20 35 38

It's not aligned

FIX: Schermata 2022-02-19 alle 20 39 30

Schermata 2022-02-19 alle 20 40 58 Schermata 2022-02-19 alle 20 37 09

The text should be aligned

Story

Bug

  • #801 fix the container for description inserted with page builder inside catalog product view
  • #35123 fix the container for description inserted with page builder inside catalog product view

Task

Fixed Issues (if relevant)

  1. magento/magento2-page-builder#<issue_number>: Issue title

Builds

Related Pull Requests

Manual testing scenarios (*)

  1. Magento 2.4.3-p1
  2. Module Page Builder Enabled (Default)
  3. Design Page - Template Product full width (Default with page builder enabled)
  4. Enter to the backoffice
  5. Create a Product and insert a description with page builder inside a row and 1 column
  6. Save

Questions or comments

Checklist

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

PierW avatar Feb 20 '22 08:02 PierW

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

paras89 avatar Oct 12 '22 16:10 paras89

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

engcom-Hotel avatar Jan 03 '24 05:01 engcom-Hotel

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run Static Tests, Unit Tests, WebAPI Tests

engcom-Hotel avatar Jan 03 '24 08:01 engcom-Hotel

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

engcom-Hotel avatar Feb 28 '24 13:02 engcom-Hotel

@magento give me 2.4-develop test instance

engcom-Bravo avatar Feb 29 '24 07:02 engcom-Bravo

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Bravo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@magento give me test instance

engcom-Bravo avatar Feb 29 '24 07:02 engcom-Bravo

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Bravo, here is your Magento Instance: https://448bc05276c29e181ed3a7033f20317d.instances-prod.magento-community.engineering Admin access: https://448bc05276c29e181ed3a7033f20317d.instances-prod.magento-community.engineering/admin_0b90 Login: 2180a752 Password: a6342b2bd182

@magento run all tests

engcom-Bravo avatar Feb 29 '24 08:02 engcom-Bravo

Hi @PierW,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  • Module Page Builder Enabled (Default)
  • Design Page - Template Product full width (Default with page builder enabled)
  • Enter to the backoffice
  • Create a Product and insert a description with page builder inside a row and 1 column
  • Save

Before: :heavy_multiplication_x: 

Screenshot from 2024-02-29 13-19-23

After: :heavy_check_mark:  

Screenshot from 2024-02-29 13-48-27

Thanks.

engcom-Bravo avatar Feb 29 '24 10:02 engcom-Bravo

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Performance Acceptance Tests, Static Tests, Unit Tests

engcom-Hotel avatar Mar 01 '24 08:03 engcom-Hotel

@magento run all tests

engcom-November avatar May 14 '24 05:05 engcom-November

@magento run Functional Tests CE, Integration Tests, Static Tests, WebAPI Tests

engcom-November avatar May 14 '24 08:05 engcom-November

@magento run Static Tests

engcom-November avatar May 14 '24 10:05 engcom-November

@magento run all tests

engcom-November avatar May 15 '24 05:05 engcom-November

@magento run Functional Tests EE, Integration Tests, WebAPI Tests

engcom-November avatar May 15 '24 07:05 engcom-November

@magento run WebAPI Tests

engcom-November avatar May 15 '24 11:05 engcom-November

The WebAPI failures on consecutive runs are different, and are flaky.

1st Run image

2nd Run image

Hence moving this pr for further processing.

engcom-November avatar May 16 '24 06:05 engcom-November

@magento run WebAPI Tests

engcom-Hotel avatar May 16 '24 13:05 engcom-Hotel

@engcom-Hotel do you think it's better to use shorthand in this case? If so, could you make the following changes? Current code:

padding-left: 15px;
padding-right: 15px;

Proposed change:

padding: 0 15px;

TuVanDev avatar Aug 16 '24 15:08 TuVanDev

Sure @TuVanDev, Please make the change. We will then proceed with this PR.

Till then moving PR to Changes Requested

Thanks

engcom-Hotel avatar Sep 13 '24 10:09 engcom-Hotel

@magento run all tests

engcom-Hotel avatar Sep 18 '24 13:09 engcom-Hotel

I don't have permission to make the changes. Thanks to @engcom-Hotel for the changes.

TuVanDev avatar Sep 18 '24 14:09 TuVanDev

Hi @PierW,

Thanks for your Contribution!!.

We have verified the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Nadia-Elements-Shell-09-26-2024_11_42_AM

Screenshot 2024-09-26 at 11 41 46

Could you please let us know if we are missing anything here.

Thanks.

engcom-Bravo avatar Sep 26 '24 06:09 engcom-Bravo