magento-coding-standard icon indicating copy to clipboard operation
magento-coding-standard copied to clipboard

Update ESLint configuration

Open fredden opened this issue 3 years ago • 9 comments
trafficstars

This has been copied from https://github.com/magento/magento2/pull/32343 This fixes https://github.com/magento/magento2/issues/32375

The ESLint configuration currently in use was last updated four years ago. A lot has changed in the JavaScript since then. Let's update the configuration to match today's standards.

Resolved issues:

  1. [x] resolves magento/magento-coding-standard#479: Update ESLint configuration

fredden avatar Dec 21 '21 18:12 fredden

@fredden we cannot deliver this update without magento2 codebase change as the whole magento2 codebase will need to comply with these rules for the static tests to pass. I'd try to deliver these changes one by one to keep failures to minimal

sivaschenko avatar Dec 22 '21 11:12 sivaschenko

@sivaschenko Thanks for the update / confirmation. How are you getting on with step 3 from https://github.com/magento/magento2/pull/32343#issuecomment-914581405? This pull request is step 4. I've offered several times to do / help with step 3, and am still waiting for access to the relevant repositories. Are you able to organise for me to have access so that this can be progressed?

fredden avatar Dec 22 '21 12:12 fredden

I'd try to deliver these changes one by one to keep failures to minimal

@sivaschenko I'm happy to open individual pull requests for these; shall I make a start on this, or do we need to wait for 'step 3' to be complete per above?

fredden avatar Dec 22 '21 12:12 fredden

@fredden yes, the other approach would be to wait for step 3. I am not able to organise additional access for you, unfortunately.

sivaschenko avatar Dec 22 '21 12:12 sivaschenko

Thanks @sivaschenko. What's the expected timeline for completion of step 3?

fredden avatar Dec 22 '21 13:12 fredden

@fredden the step 3 is not planned at the moment

sivaschenko avatar Dec 22 '21 13:12 sivaschenko

How can we therefore progress with this work?

fredden avatar Dec 22 '21 14:12 fredden

@sivaschenko Please can you provide a status update on this? Am I allowed to help update/fix your linter yet?

fredden avatar Oct 14 '22 16:10 fredden