module-blog icon indicating copy to clipboard operation
module-blog copied to clipboard

Published 20 hours ago • verified publisher icon magefan

fix Magento2.Legacy.EscapeMethodsOnBlockClass

Open Morgy93 opened this issue 1 year ago • 2 comments

Using escape methods on $block is deprecated via Magento2.Legacy.EscapeMethodsOnBlockClass. Ref.: https://github.com/magento/magento-coding-standard/blob/v33/Magento2/Sniffs/Legacy/EscapeMethodsOnBlockClassSniff.php

This PR fixes it.

Morgy93 avatar Sep 02 '24 17:09 Morgy93

@Morgy93 , thank you for your PR. Unfortunatly we cannot approve it now, as we still keep compatibility with Magento 2.3.0, and $escaper is available only in Magento >= 2.4.0.

Once we drop Magento 2.3.x compatibility we will update the templates and add $escaper

magefan avatar Sep 16 '24 10:09 magefan

I am wondering why you keep 2.3.0 support if only 2.4.4+ are supported officially. (https://experienceleague.adobe.com/en/docs/commerce-operations/release/planning/lifecycle-policy) It sounds like life support for something long dead. 😅 2.3.0 support ended over two years ago.

I would wish you focused more on motivating people to update, rather than rewarding them for using outdated and security-critical software. 😊

Morgy93 avatar Sep 16 '24 11:09 Morgy93