language-formatters-pre-commit-hooks icon indicating copy to clipboard operation
language-formatters-pre-commit-hooks copied to clipboard

Regression: Formatting broken on cargo workspaces

Open GUIpsp opened this issue 1 year ago • 2 comments
trafficstars

#217 unfortunately causes the rust formatting hook to break on cargo workspaces.

See https://github.com/GUIpsp/language-formatters-pre-commit-hooks-bug-demo for a minimal repro. Just clone and pre-commit run --all

GUIpsp avatar Aug 24 '24 02:08 GUIpsp

@GUIpsp sorry for the very large lag in here.

What is the issue that cargo workspaces are providing to the repo? what is the expectation that you would have?

By checking the repo (did not try to run pre-commits on it), I see that it does not adhere to a rust workspace, which makes me think that the repo per se is somewhat inconsistent with the expectations of a Rust repository.

At the same time I would be interested to hear more about the expectations you might have to determine if there could be some variations that can be done to smooth the experience

macisamuele avatar Oct 24 '24 20:10 macisamuele

Hey, no worries about the response time.

I am not sure what you mean by "It doesn't adhere to a rust workspace" - there is a root Cargo.toml with the workspace.members element - and indeed cargo build works as expected.

GUIpsp avatar Oct 24 '24 22:10 GUIpsp