messenger-platform-go-sdk icon indicating copy to clipboard operation
messenger-platform-go-sdk copied to clipboard

Support for Button Templates

Open seenickcode opened this issue 8 years ago • 6 comments

Ability to send Button Templates without receiving an error from Facebook, as this feature never worked for the latest Facebook Send API. Button templates basically require a 'buttons' field rather than an 'elements' field.

seenickcode avatar Jun 26 '17 16:06 seenickcode

Coverage Status

Coverage decreased (-1.5%) to 91.367% when pulling 1752100b8c14d9a5c2d73e3a14cf714e3222ba84 on seenickcode:master into b41e9390cad301d1da13909abf9d2858c55ce521 on maciekmm:master.

coveralls avatar Jun 26 '17 16:06 coveralls

Coverage Status

Coverage decreased (-5.7%) to 87.185% when pulling a4cababa6bf65310851e0459a2a60c203e9245e0 on seenickcode:master into b41e9390cad301d1da13909abf9d2858c55ce521 on maciekmm:master.

coveralls avatar Jun 28 '17 13:06 coveralls

Coverage Status

Coverage decreased (-5.7%) to 87.185% when pulling 07754784f8edc346a9b370108512075ade4e1458 on seenickcode:master into b41e9390cad301d1da13909abf9d2858c55ce521 on maciekmm:master.

coveralls avatar Jun 29 '17 15:06 coveralls

@seenickcode Thanks for your contribution, but unfortunately the code neither compiles nor it has required coverage. First of all, please fix import paths. When contributing to Go projects it's advised to clone the repository to the directory which path reflects the location of the mainstream repo, not the fork. That way, albeit not importable from the outside world, the code works locally.

maciekmm avatar Jul 06 '17 05:07 maciekmm

Does this article explain a recommendation properly? http://blog.campoy.cat/2014/03/github-and-go-forking-pull-requests-and.html if so I will follow it and re-submit.

seenickcode avatar Aug 07 '17 20:08 seenickcode

@seenickcode yes, 👍

maciekmm avatar Aug 07 '17 20:08 maciekmm