wiremock-spring-boot icon indicating copy to clipboard operation
wiremock-spring-boot copied to clipboard

Published 20 hours ago • verified publisher icon maciejwalkowiak

GH-28: add support for multiple property injection

Open rfelgent opened this issue 1 year ago • 4 comments

hi @maciejwalkowiak ,

here is the pull request for https://github.com/maciejwalkowiak/wiremock-spring-boot/issues/28.

Please let me know what else I can do for this pull request to be accepted.

rfelgent avatar Mar 05 '24 07:03 rfelgent

Hi @maciejwalkowiak ,

I added some hints about the multiple property injection feature. Please have look at the README.md. While updating the README.md, 2 questions came into my mind:

  • should we rename the attribute from property to properties (hard migration with breaking changes) or
  • should we add another attribute called properties and it can co-exists with property (soft migration, no breaking changes)

Greetings

PS: I am not used to work with forks. I created another PR for updating the README.md https://github.com/maciejwalkowiak/wiremock-spring-boot/pull/31/

rfelgent avatar Apr 01 '24 15:04 rfelgent

Thanks @rfelgent! Thanks for updating readme, don't worry it is in another branch, i'll put it into main all together when we have this PR ready.

maciejwalkowiak avatar Apr 02 '24 04:04 maciejwalkowiak

Hi @maciejwalkowiak ,

I renamed/refactored the attributes property and properties of ConfigureWireMock. Please have a look at https://github.com/maciejwalkowiak/wiremock-spring-boot/pull/32/files

rfelgent avatar Apr 04 '24 08:04 rfelgent

Hi @maciejwalkowiak ,

please let me know what else I can do for this merge request.

rfelgent avatar Apr 11 '24 10:04 rfelgent