warcreate icon indicating copy to clipboard operation
warcreate copied to clipboard

All tabs headers inserted in resulting warc file

Open diegito opened this issue 11 years ago • 3 comments

When getting the warc file from one tab, when I edit it I see that also other headers from other opened tabs I have are inserted. Perhaps the filtering inside code.js for chrome.webRequest.onBeforeSendHeaders and chrome.webRequest.onHeadersReceived does not work?

diegito avatar Jun 20 '14 21:06 diegito

Cause of this is the asynchronous behaviour of getSelected and onBeforeSendHeaders.addListener(), see http://stackoverflow.com/questions/24538439/chrome-extensions-webrequest-filtering-by-tabid-not-working.

diegito avatar Jul 04 '14 16:07 diegito

I can imagine an instance where a user will load sites in two different tabs and would want to create WARCs from each tab (e.g., archiving all sections of a website). The issue here is all tabs' queried are being lumped together. The solution might be to have some associate array -like (because JS only has Objs) structure to attribute data from each tab to its respective tab and, on pressing the Generate WARC button, reference the array as a basis for what to write.

machawk1 avatar Jul 25 '14 17:07 machawk1

Related #7

machawk1 avatar Jul 25 '14 17:07 machawk1