Double-Click when onEdit enabled

[liester]

In the Features portion of the documentation it says when 'onEdit' is enabled there should be Double-Click Edit Mode.

I'm not getting this functionality with the following usage:

I unsure if it is how I've used the component, not supported, or an issue. Its important when my application is on touch screens as I don't have the 'hover' to show the edit/add/remove icons. Any information would be helpful. Thanks in advance.

[liester]

After looking through the other issues I saw this one: https://github.com/mac-s-g/react-json-view/issues/91 Which wintercounter references the Ctrl+Click for editing. Then looking more closely at the demo it does say Ctrl+Click for editing. So maybe its just a lag in the documentation in the README.md. It doesn't solve me touch screen problem but at least it makes sense.

[mac-s-g]

Thanks for pointing this out. I updated the docs for now - but I'm planning on playing around with dbl-click edit a bit more.

would anyone else prefer double click edit mode rather than ctrl+click?

[mac-s-g]

I remember now that using double-click to trigger edit mode interferes with the onSelect listener. onSelect is invoked every time a value is clicked.

[mac-s-g]

opening this up to the community for discussion.

how would you like to see the keyboard and mouse controls change?

[pravdomil]

+1

[villesau]

I'd like to be able to just click the value which would open the text input.

[mrbfrank]

I'm trying to get a single click of each value to open the editor. My first thought is using onSelect to emulate a click on <div class="click-to-edit" ...>, but a new boolean prop like editOnSelect would be nice.