rjsf-tailwind icon indicating copy to clipboard operation
rjsf-tailwind copied to clipboard

Can this be used as an @rjsf theme?

Open naskovai opened this issue 1 year ago • 5 comments
trafficstars

Here is the themes section of the rjsf docs: https://rjsf-team.github.io/react-jsonschema-form/docs/usage/themes

Similarly to other themes, can we have this work as well? It will make the adoption of your nice lib much easier.

import Form from '@rjsf/tailwind';

naskovai avatar Aug 16 '24 20:08 naskovai

I did think about doing that, but it would make it tough for consumers to customize it to their liking. Also, I think I need to be a part of the @rjsf organization on npm in order to publish a package using that prefix.

m6io avatar Aug 18 '24 21:08 m6io

@m6io I'm sure the authors of @rjsf would be interested in hearing from you. Might not be a bad idea to make an appearance on this issue thread and let it be know if you support moving the codebase into the @rjsf umbrella. No judgment one way or the other (you'd probably feel some added responsibility by joining the organization), just feel like you did some good work, people are looking for it in that org, and maybe some of them (like myself) find this repo on Google, but some others might give up without official support.

As for making it tough to customize, I don't think this would be the case. You could as a pre-condition to donating your code to @rjsf organization, be made a member and ask to have the final say on how this repo evolves, or you could let it go and have someone else maintain it, but ultimately your opinion would matter a great deal, so you can always influence its direction.

Thanks for sharing your hard work, I hope to pay it forward one day.

gamedevsam avatar Nov 17 '24 21:11 gamedevsam

@gamedevsam I'll give it some more thought. I really only made this repo as a way to demonstrate how one can customize rjsf using Tailwind (I have a "vanilla" version as well for the same purpose: https://github.com/m6io/rjsf-vanilla)

That said, given how difficult it is to truly customize rjsf (for me, at least), I actually created my own set of un-opinionated and headless form generator packages (https://github.com/m6io/react-formgen, https://www.npmjs.com/package/@react-formgen/json-schema) to address a lot of the customization issues I was having with rjsf, and hopefully help others out as well.

Thanks for sharing your hard work, I hope to pay it forward one day.

I'm glad you weighed in! Side note; as someone struggling to learn game dev, I'm always looking for resources and devs to learn from, so feel free to plug whatever :)

m6io avatar Nov 22 '24 13:11 m6io

@m6io best way to start game dev is to pick a game jam and just build a game. If you don't know where to start, pick a game engine and look at its samples for inspiration, ex: https://phaser.io/examples/v3.85.0

gamedevsam avatar Nov 22 '24 17:11 gamedevsam

If you'd like more deets, hit me up on X: https://x.com/gamedevsam

I always love to connect with fellow React & game developers :)

gamedevsam avatar Nov 22 '24 17:11 gamedevsam