grafana_api icon indicating copy to clipboard operation
grafana_api copied to clipboard

Add interface to health and method to datasources (proxy-data)

Open peekjef72 opened this issue 5 years ago • 4 comments
trafficstars

Pull Request Template

Description

  • Add interface to health grafana info (/api/heath)
  • Add new method on datasource get_datasource_proxy_data (/api/datasource/proxy...) to be able to collect data info through grafana.

All the features are required for a tool to build real grafana-snapshots containing data.

Have you written tests?

  • [ ] Yes
  • [X] No => no specific tests but, I use the new features for a tool using grafana_api, that will be soon on github (grafana-snapshots)

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

peekjef72 avatar Oct 24 '20 13:10 peekjef72

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d2e1520). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage        ?   84.88%           
=======================================
  Files           ?       17           
  Lines           ?      655           
  Branches        ?        0           
=======================================
  Hits            ?      556           
  Misses          ?       99           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2e1520...281f5ae. Read the comment docs.

codecov[bot] avatar Oct 24 '20 13:10 codecov[bot]

Any Updates? When it will be merged?

lodgvideon avatar Mar 11 '21 14:03 lodgvideon

Sorry but what is required in fact for that PR to be merged, in practice ? I'm probably stupid, but really can't find what to do...

peekjef72 avatar Jan 08 '22 09:01 peekjef72

Hi there,

we just integrated this patch into the grafana-client-fork (see #88) on behalf of https://github.com/panodata/grafana-client/pull/5. Thank you very much, @peekjef72!

With kind regards, Andreas.

amotl avatar Feb 06 '22 23:02 amotl