birday icon indicating copy to clipboard operation
birday copied to clipboard

Published 20 hours ago • verified publisher icon m-i-n-a-r

Migrate to Kotlin DSL, Update zh-rCN strings, Minor changes

Open lightsummer233 opened this issue 1 year ago • 3 comments

targetSdk 35 Update Gradle & Kotlin Add props Don't use android:fitsSystemWindows="true" in bottom sheet Apply toolchain resolver. This can get rid of Gradle's strong dependence on JDK version Use new version of packaging (increased apk size, this is not because it contains more data but because the data is now uncompressed, the advantage this has is that the actual installed app size is decreased) Add gradlew.bat back for Windows user

lightsummer233 avatar Jun 23 '24 02:06 lightsummer233

Thanks! I'll take a look at your commits in the next few days 😄

m-i-n-a-r avatar Jul 02 '24 13:07 m-i-n-a-r

There are indeed advantages in using Kotlin over Groovy, so your modification makes sense. I'm super glad you're contributing, but could you split the next pull request into smaller pieces? So I can merge them gradually? I know it means more work, but in this way I will merge them faster :) thanks! Regarding this one, don't worry, I should merge it soon.

m-i-n-a-r avatar Jul 03 '24 08:07 m-i-n-a-r

I'm super glad you're contributing, but could you split the next pull request into smaller pieces?

Yes, I will. I'm sorry to bring more works for you to do. Thanks for your work.

lightsummer233 avatar Jul 03 '24 08:07 lightsummer233