lyft-android-sdk icon indicating copy to clipboard operation
lyft-android-sdk copied to clipboard

Published 20 hours ago • verified publisher icon lyft

Android 11 - It is not redirecting on browser and Lyft app

Open deepbhavsar opened this issue 4 years ago • 8 comments

I am checking Lyft button but I found that it is not redirecting on browser Lyft app. It require to upgrade code for intent and deeplinking.

deepbhavsar avatar Apr 23 '21 07:04 deepbhavsar

were you able to resolve this issue?

earamsey avatar Jan 12 '22 19:01 earamsey

Yeah, deep linking doesn't work when you have targetSDK set to 30 and above. https://www.reddit.com/r/androiddev/comments/ni33zr/anyone_else_experience_completely_broken_deep/

makkhay avatar Mar 08 '22 19:03 makkhay

I was also having issues getting deep links to work when android targetSDK is set to 30 and above. Still fairly new at android development. Not sure what the best practice is in this case. After some reading. We manage to fix it within our own app by adding a <queries> element in the Android manifest.

I created a branch with updates to the lyft sample project(https://github.com/mikaaali/lyft-android-sdk/tree/defect/package-visibility-in-android#readme). Hopefully, you guys find this helpful.

mikaaali avatar Mar 11 '22 21:03 mikaaali

@mikaaali hmm interesting, just checked your sample project and it looks like only the Pixel devices are impacted ? I tested on my Samsung device and the deeplinking worked just fine, but however, the drop off location data was not retrieved by the Lyft native app. When you login in to the Lyft native app, were you able to see the drop off location data ?

makkhay avatar Mar 11 '22 22:03 makkhay

@makkhay yeah it's interesting. I think both Pixel and Samsung are impacted when targetSDK is set to 30 and above.
Like you said Samsung seems to works halfway, it does launch deep link but without the drop-off location data.

So far I haven't observed any error once I updated the app by following this guide: https://developer.android.com/training/package-visibility

mikaaali avatar Mar 12 '22 01:03 mikaaali

@mikaaali One quick question, you said you were able to fix the issue by adding a , I am guessing you added Lyft SDK as a lib instead from the gradle ? Because as far as I know, when you import from gradle, you wouldn't be able to make changes to the SDK code. Thanks

makkhay avatar Mar 14 '22 21:03 makkhay

@makkhay the Lyft SDK is added as a dependency in the build.gradle file. No code change is needed for Lyft SDK to solve the deep link issue.

mikaaali avatar Mar 14 '22 22:03 mikaaali

@mikaaali oh thanks, got it working.

makkhay avatar Mar 15 '22 00:03 makkhay