swift-responsive-textfield icon indicating copy to clipboard operation
swift-responsive-textfield copied to clipboard

Adding responsiveTextFieldPlaceholderColor modifier to update a ResponsiveTextField's placeholder color

Open mergesort opened this issue 1 year ago • 4 comments
trafficstars

mergesort avatar Feb 27 '24 15:02 mergesort

I don't think this failure is me, I think it's flaky CI.

mergesort avatar Feb 27 '24 16:02 mergesort

LGTM - do you think you might be able to add a snapshot test?

lukeredpath avatar Feb 27 '24 17:02 lukeredpath

I need to update CI to use the correct simulator version as I think Xcode has been updated.

lukeredpath avatar Feb 27 '24 17:02 lukeredpath

Added a test, but I've never used snapshot tests so let me know if that works!

mergesort avatar Feb 28 '24 01:02 mergesort

@mergesort I just tried to update this to bring in the latest main and I think it updated your main branch. Can you try and revert the package changes in this PR please and I can get it merged in.

lukeredpath avatar Jul 31 '24 19:07 lukeredpath

Done!

mergesort avatar Jul 31 '24 20:07 mergesort

@lukeredpath Just as a heads up, I don't think the CI failures are cause of the code I changed.

mergesort avatar Aug 01 '24 14:08 mergesort