clickatell icon indicating copy to clipboard operation
clickatell copied to clipboard

Hi Luke

Open calvincorreli opened this issue 15 years ago • 2 comments
trafficstars

I've changed the way error handling works so if you send multiple messages at once, we won't raise an exception just because one of those messages failed. You'd really want to be able to parse the response and deal with them indidivually.

Plus, when the error message ends with a colon, the error parsing returned empty code and messages.

Here's the error I was getting back:

ERR: 105, Invalid Destination Address To: ERR: 105, Invalid Destination Address To: ERR: 105, Invalid Destination Address To:

(many more like these)

//Lars

calvincorreli avatar Oct 01 '10 09:10 calvincorreli

Hi Lars

Thanks for this. Whilst I appreciate the pull request, these changes really need some tests before I can merge them.

Thanks Luke

lukeredpath avatar Oct 01 '10 15:10 lukeredpath

Yeah yeah yeah, always the tests ... ;)

Had a problem to solve, so just solved it.

I have several other things, I might have to add - concat and unicode being the first two that come to mind.

Will keep the thing about tests in mind :)

//Lars

calvincorreli avatar Oct 01 '10 17:10 calvincorreli