LRSlidingTableViewCell icon indicating copy to clipboard operation
LRSlidingTableViewCell copied to clipboard

Major rebase; add some delegate methods

Open a2 opened this issue 13 years ago • 4 comments
trafficstars

a2 avatar Feb 18 '12 03:02 a2

Thanks a lot, this looks useful. Before I can merge, I'd appreciate it if you'd make some style changes. The spacing of your methods is a bit off and doesn't match the rest of the code.

It should be:

- (void)addSwipeGestureRecognizer:(UISwipeGestureRecognizerDirection)direction;

Not:

- (void) addSwipeGestureRecognizer: (UISwipeGestureRecognizerDirection) direction;

For example. Also don't leave spaces in methods between the arguments, e.g.;

[self addSwipeGestureRecognizer:UISwipeGestureRecognizerDirectionRight];

Instead of:

[self addSwipeGestureRecognizer: UISwipeGestureRecognizerDirectionRight];

Please also keep opening braces of statements (if/while/switch etc.) on the same line. Only opening braces for methods should be on a new line. Always uses braces for if statements.

There's also no need to modify the copyright statements or LICENSE file. I can add your name to a contributors list in the README.

Thanks a lot.

lukeredpath avatar Feb 18 '12 13:02 lukeredpath

Wouldn't it just be easier to merge the pull request and make the changes? I'm sure it would be easier for both of us.

a2 avatar Feb 18 '12 16:02 a2

I'm too busy right now so it will have to wait, thanks. Generally speaking, it's much more helpful when contributing to try and stick to the style that has been used by the original author - it avoids issues like these. Thanks.

lukeredpath avatar Feb 18 '12 17:02 lukeredpath

@lukeredpath how to add buttons behinde the cell?

ashishfission avatar Sep 29 '12 18:09 ashishfission