Luke Edwards

Results 266 comments of Luke Edwards
trafficstars

I closed another issue that duplicated this one. I did not close this thread.

Hey, traveling today. I'll take a look at all your comments later today, circa 8 hours. Thanks ~

@icdindia There _is_ a way to manage the widths & placements on responsive breakpoints. As you can imagine, I can't impose a default responsive system, because everyone's desired implementation is...

Does it look merged? :D Waiting because all these PRs have varying results depending on the minor (or patch) version when benchmarking. There’s needs to be a clear/obvious pattern before...

Hey, thanks! This is already done in #26 – I haven't been able to setup a clean bench environment to test this out yet. Caching a `foo.length` used to not...

Just to be clear – since some may be seeing this as a PR for adding native ESM support – this is only adding an ESM file, which could be...

Shouldn't this just be userland? I wouldn't want this, ever, for example. Might be as simple as: ```js globalThis.__webpack_public_path__ = ASSET_PATH; ``` With a [`define`](https://esbuild.github.io/api/#define) for `ASSET_PATH`

Oh I see, sorry. I thought you were specifically asking for esbuild to output the webpack variable for compatibility purposes with imported code. Nvm :)

> For example, plugins don't really compose right now. Would it be possible to clarify this? Maybe I'm being too short-sighted, but I think the main need here is that...

@evanw Thanks for the insights – unfortunate, but not super surprising. Spawning processes is expensive. I wonder if it might make a difference if using [`worker_threads`](https://nodejs.org/dist/latest-v14.x/docs/api/worker_threads.html#worker_threads_worker_threads) instead, as opposed to...