uint128 icon indicating copy to clipboard operation
uint128 copied to clipboard

Published 20 hours ago • verified publisher icon lukechampine

Add tests for math/bits methods

Open lukechampine opened this issue 5 years ago • 4 comments

The following methods are missing test coverage:

  • TrailingZeros
  • OnesCount
  • RotateLeft
  • RotateRight
  • Reverse
  • ReverseBytes
  • Len

Ideally, you should copy the test cases from math/bits: https://golang.org/src/math/bits/bits_test.go (specifically, you'll probably want to use the tab array from the bottom of the file).

Feel free to submit tests for all of these, or just one. You can also convert the existing LeadingZeros test to match the testing format used in math/bits.

lukechampine avatar Oct 02 '20 16:10 lukechampine

@lukechampine Can you assign that to me? I will do it.

satyabansahoo2000 avatar Oct 06 '20 06:10 satyabansahoo2000

Sure, go for it!

lukechampine avatar Oct 06 '20 14:10 lukechampine

Please, take a look at this. #8 If anything needed to be removed or added, inform me.

satyabansahoo2000 avatar Oct 07 '20 06:10 satyabansahoo2000

@tomaszjonak @cvhariharan @pedroandrade anyone willing to take this issue?

lukechampine avatar Oct 15 '20 16:10 lukechampine