cpan-selenium-rc-perl icon indicating copy to clipboard operation
cpan-selenium-rc-perl copied to clipboard

Update Selenium.pm

Open James-Switzer opened this issue 12 years ago • 5 comments

Fixed bug in get_string_array where instead of correctly returning an empty array when there are no results it returns an array containing a single empty string. The new code uses a negative lookbehind assertion to split on unescaped commas. It then uses a map to remove the escape characters from the list of strings.

James-Switzer avatar Oct 14 '13 20:10 James-Switzer

Are you able to become a co-maintainer? I don't have time for this module lately.

lukec avatar Oct 15 '13 03:10 lukec

What kind of help are you looking for and what kind of time commitments would it involve? I don't have tons of free time myself, but I might be able to get a little time at work to help out. I've pitched my boss on doing it for the street cred / OSS karma and he sounds interested, but more details make for an easier sell.

jamess

On Mon, Oct 14, 2013 at 8:39 PM, Luke Closs [email protected]:

Are you able to become a co-maintainer? I don't have time for this module lately.

— Reply to this email directly or view it on GitHubhttps://github.com/lukec/cpan-selenium-rc-perl/pull/7#issuecomment-26307243 .

James-Switzer avatar Oct 16 '13 21:10 James-Switzer

Hi,

I would just like someone to take over being the maintainer. I don't follow selenium much anymore, so I'm out of date when it comes to fixing things.

It's not very much work, mostly accepting the odd patch or making a release. I can help advise if you'd like.

Best, Luke

On Wed, Oct 16, 2013 at 2:54 PM, James Switzer [email protected]:

What kind of help are you looking for and what kind of time commitments would it involve? I don't have tons of free time myself, but I might be able to get a little time at work to help out. I've pitched my boss on doing it for the street cred / OSS karma and he sounds interested, but more details make for an easier sell.

jamess

On Mon, Oct 14, 2013 at 8:39 PM, Luke Closs [email protected]:

Are you able to become a co-maintainer? I don't have time for this module lately.

— Reply to this email directly or view it on GitHub< https://github.com/lukec/cpan-selenium-rc-perl/pull/7#issuecomment-26307243>

.

— Reply to this email directly or view it on GitHubhttps://github.com/lukec/cpan-selenium-rc-perl/pull/7#issuecomment-26462177 .

lukec avatar Oct 19 '13 15:10 lukec

I can take it, Luke.

On Saturday, October 19, 2013, Luke Closs wrote:

Hi,

I would just like someone to take over being the maintainer. I don't follow selenium much anymore, so I'm out of date when it comes to fixing things.

It's not very much work, mostly accepting the odd patch or making a release. I can help advise if you'd like.

Best, Luke

On Wed, Oct 16, 2013 at 2:54 PM, James Switzer <[email protected]<javascript:_e({}, 'cvml', '[email protected]');>>wrote:

What kind of help are you looking for and what kind of time commitments would it involve? I don't have tons of free time myself, but I might be able to get a little time at work to help out. I've pitched my boss on doing it for the street cred / OSS karma and he sounds interested, but more details make for an easier sell.

jamess

On Mon, Oct 14, 2013 at 8:39 PM, Luke Closs <[email protected]<javascript:_e({}, 'cvml', '[email protected]');>>wrote:

Are you able to become a co-maintainer? I don't have time for this module lately.

— Reply to this email directly or view it on GitHub<

https://github.com/lukec/cpan-selenium-rc-perl/pull/7#issuecomment-26307243>

.

— Reply to this email directly or view it on GitHub< https://github.com/lukec/cpan-selenium-rc-perl/pull/7#issuecomment-26462177>

.

— Reply to this email directly or view it on GitHubhttps://github.com/lukec/cpan-selenium-rc-perl/pull/7#issuecomment-26652422 .

joemcmahon avatar Oct 20 '13 14:10 joemcmahon

hi all, I can handle the merge and release, as luke already threw me commitbit.maintainership many months back. Before merge I would prefer some level of unit testing on your change if possible?

Thanks, Matt

mattp- avatar Oct 21 '13 15:10 mattp-