react-native-awesome-pin icon indicating copy to clipboard operation
react-native-awesome-pin copied to clipboard

Unable to install

Open Yasir12598 opened this issue 2 years ago • 5 comments

I am trying to install by npm install react-native-awesome-pin --save but gives an error.

"react": "18.1.0",
"react-native": "0.70.0",

Below is the error.

PS E:\Projects\HisabKitab-Dcodax-Products\HisabKitab>  npm install react-native-awesome-pin --save
npm ERR! code ENOENT
npm ERR! syscall spawn git
npm ERR! path git
npm ERR! errno -4058
npm ERR! enoent An unknown git error occurred
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Muhammad Yasir\AppData\Local\npm-cache\_logs\2023-02-06T06_01_17_011Z-debug-0.log

Yasir12598 avatar Feb 06 '23 06:02 Yasir12598

I believe this has to do with our peerDependancies in package.json:

"peerDependencies": {
    "react": "16.2.0",
    "react-native": "0.53.0"
  },

If you make a PR to remove this, I can publish the package and add you as a contributor? It should fix this issues :)

lukebrandonfarrell avatar Feb 06 '23 14:02 lukebrandonfarrell

I have the same error. I'll create the PR to remove "peerDependencies" in package.json

leo-ori avatar Mar 31 '23 20:03 leo-ori

I've created the branch I only need rights to push it

leo-ori avatar Mar 31 '23 22:03 leo-ori

@leo-ori Could you create a PR? If you clone the repo and do the work on the cloned repo, you can then open a PR from your closed repo to this repo, and I can review. That way it goes through all our review and testing process, and not directly pushed to main.

Thank you :)

lukebrandonfarrell avatar Apr 02 '23 14:04 lukebrandonfarrell

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

lukebrandonfarrell avatar Apr 02 '23 14:04 lukebrandonfarrell