Luke Dashjr

>Not sure. Wasn't the goal the exact opposite, so that it is easier to cat the hashes once and as many signatures as one wants? You can still do that...

It seems @DrahtBot stops short of making the full SHA256SUMS file?

>It would be good to list at least one benefit, otherwise the benefits of this change are unclear. Having a single file to download for the signatures is simpler for...

It seems this isn't enough - OpenPGP explicitly identifies the data as either binary or text: https://datatracker.ietf.org/doc/html/rfc4880#section-5.2.1 So I guess the only way to support a combined file would be...

Apparently stripping the final newline would fix this, but a new issue arose: if the signature is detached, it will only verify a pre-canonicalized (DOS-encoded and final newline stripped) file....

1c1bd6cbc6d96fff7f67186aeb57adfe0ee872c4 doesn't build

Why was it rebased? Just seems to make it harder to review the changes...

>If the environment variable BITCOIN_TEST_PATH is set, use its value as the test's working directory, rather than a randomly-named path in /tmp/test_common_Bitcoin\ Core/ >When the test starts, remove the working...

Not quite, I'm more concerned about a situation where `BITCOIN_TEST_PATH` might be `/home/user` or something else weird. While it's a crazy user error, nobody expects setting an env variable would...

>Probably, it is because the benchmarks, same as the unit tests, create temp directories. Which may be faster to access than regular directories. Is it, though? I would think the...