Support Videos

[Muhammad-Altabba]

trafficstars

• Tested with .mp4 on Chrome

• Done on fast. So there could be things like : - Duplication on CSS classes usage - Some scenarios may have not been handled - Many enhancements could be done

• Related to https://github.com/lukasz-galka/ngx-gallery/issues/149

[Muhammad-Altabba]

I created a fast NPM package at https://www.npmjs.com/package/ngx-image-video-gallery to be used in the mean time. However, because I did not want to really create a new package I did not do a full renaming. So, to use ngx-image-video-gallery, you have so import from it like this: import { NgxGalleryImage } from 'ngx-image-video-gallery/dist/bundles/ngx-gallery.umd.js' I will not maintain that package. And I will most likely delete it once this pull request is approved.

[Muhammad-Altabba]

Hello @myerffoeg, Do you mind accepting this pull request? And you can after that modify what need enhancements? Best regards,

[Muhammad-Altabba]

Hi @myerffoeg, Kindly accept the changes if there are no issues. Or else some developers may start forking my fork like https://github.com/alvarovazquezrodriguez/ngx-gallery

[codemx]

@myerffoeg are you considering merging @Muhammad-Altabba 's updates to the library ? please consider his request

[yashwp]

@myerffoeg Please merge this PR and also, update the package for Angular 8 support.

[geofmigliacci]

@codemx @yashwp @Muhammad-Altabba I do not have the write access right to do that, I have just done a code review to accelerate the process for the repository author.

If you want to accelerate the process you can : review the code, suggest improvements or contact the author @lukasz-galka .

[Muhammad-Altabba]

Thanks @myerffoeg,

Hello @lukasz-galka, Do you mind merging this pull request?

[Muhammad-Altabba]

Hello @lukasz-galka

[codemx]

Hi @lukasz-galka , can we kindly proceed with this request?

[lukasz-galka]

Hi guys, I will take a look on it on Monday

[codemx]

Hi @lukasz-galka we are still waiting for this.. can you kindly proceed?

[steveacalabro]

@lukasz-galka @codemx Any luck on this feature?

[codemx]

@steveacalabro Not sure why @lukasz-galka is not looked at this as he promised around 6 weeks ago. he is the owner of this and we all are waiting for his action. @Muhammad-Altabba is there any alternatives ?

[dankcellar]

Is this getting merged anytime soon? @lukasz-galka @steveacalabro

[solcre-gr]

+1

[kolkov]

I will try to implement in my Angular 8++ repo.

[kolkov]

https://www.npmjs.com/package/@kolkov/ngx-gallery

[hverma]

@lukasz-galka will this request be merged soon?

[hverma]

https://www.npmjs.com/package/@kolkov/ngx-gallery

@kolkov Thx for creating an angular 8 version. Wondering, if you will merge these changes to your repo soon?

[Etmutt]

definetly that would be a very nice addition

[kolkov]

This merged. Try latest version please.

[marcioveiga16]

This should be merged, i'm already using, but i believe i found a bug, if i have more than one video when i click to change to the next one, it changes to the same one, but if i place an image between the videos it works fine.

[Muhammad-Altabba]

Hello guys, It is really a long time passed :smile: . I had the library published on https://www.npmjs.com/package/ngx-image-video-gallery long time ago and there are about 19 weekly downloads :smile: .