kirby-versions icon indicating copy to clipboard operation
kirby-versions copied to clipboard

List the changes made in each commited file

Open squareclouds opened this issue 3 years ago • 6 comments

Is your feature request related to a problem? Please describe.

Not problem related, new feature

Solution you'd like

it would be perfect if the user could see what the actual changes were, much like in github/gitlab, etc commits where you can see the previous and new versions side by side

Potential alternatives

otherwise showing only the new changes might be enough

Additional context

in a multi-user setup and automatic backups this would be incredibly useful since the title/labels would not be descriptive enough and people wouldnt know exactly what to revert.

squareclouds avatar Aug 18 '22 07:08 squareclouds

It would be doable to display the list of changes (list of changed files and their status, e.g. added, deleted, renamed, modified) in a dialog that can be accessed from the options dropdown of each version.

lukasbestle avatar Aug 18 '22 19:08 lukasbestle

that would be a great start! in that case, since a list of the files changed would be available, do you think it would be possible to revert individual files as well and not the whole commit as a more advanced feature?

and the more complex would be adding the side-by-side comparison for each file so the editors can see the lines that were changed and decide based on that if they want to revert a file.

reverting the whole commit should of course still be available, just how you have it right now.

i would be willing to fund this features a bit in case you think they are quite difficult to implement.

squareclouds avatar Aug 20 '22 08:08 squareclouds

These features are both quite difficult to implement to be honest. The backend code would be doable but needs testing. But the user interface changes require a rewrite of the frontend code.

At the moment I'm quite booked out. How urgently do you need the features?

lukasbestle avatar Aug 20 '22 13:08 lukasbestle

oh ok. well the most important part in my opinion would be the ability to see the list of changed files in each commit. that was not so complicated if i understood correctly, right?

to see the actual changes inside a file would be the next important milestone i think (just realized it does not need to be the side by side view between the version i am inspecting and the previous one. i guess highlighting the changed lines in the version i am inspecting is more than enough to be able to see what parts of the content changed)

and the deluxe version would be with the ability to only revert a single file and not the whole commit.

for the last 2 features, do you think you would have time in the next 4-5 weeks?

squareclouds avatar Aug 20 '22 14:08 squareclouds

For the next 3 weeks I'm fully booked out. I'll get back to you. :)

lukasbestle avatar Aug 20 '22 15:08 lukasbestle

perfect, thank you!

squareclouds avatar Aug 22 '22 08:08 squareclouds