Lukas Reining

Results 54 comments of Lukas Reining

The issue is an "inline cc-pc licensed" method. I am not 100% sure if cc-pd is compatible with Apache-2.0, but I think so. If it is, we can accept this....

> The default provider is always the same since we're using a global singleton. Yes for the default provider this would lead to strange behavior as @beeme1mr says. > However,...

On the other hand one could argue that what @wichopy proposed fits perfectly to what the context mutator does. There the domain is also implied from the context and transparent...

I will have a look at what is wrong with the e2e test tomorrow @kaushalkapasi :)

Sorry for taking time @kaushalkapasi, many of us have been at KubeCon. Will have a look tomorrow or the day after :)

@toddbaert @jonathannorris The js-sdk-contrib version is deprecated and the js-sdk one is deployed. We can close this :)

> `console.debug` is an alias for `console.log` in [node.js](https://nodejs.org/api/console.html#consoledebugdata-args). That's why we decided to no-op debug by default. In this case, debug feels like the correct log level but it...

Thanks for opening the issue @MillerSvt! As @beeme1mr says, the design of the SDK is to never let users create the API instances. Instead, the global instance is meant to...

> Adding a lazy option into providers that allows them to delay initialization until they're provided a context later, essentially what our wrapper does currently (very jankily), also seems like...

> I think it could make sense as an option during provider registration. It would only make sense for static context. Yes, that's also what I think. > We should...