action-shellcheck
action-shellcheck copied to clipboard
ludeeus
feat: support ARM runners
Sample run: https://github.com/LesnyRumcajs/action-shellcheck/actions/runs/13140996529
Adds support for ARM-based runners.
Closes https://github.com/ludeeus/action-shellcheck/issues/112
Even though arm runners are super common, you're probably better off forking the repo and adding support for ARM there.
Even though arm runners are super common, you're probably better off forking the repo and adding support for ARM there.
Could you please elaborate why this would be a better solution? Different architecture is already supported by the upstream tool. I'd find it confusing if I had to use different actions for different runners.
The maintainer has zero interest in adding ARM support last I and others checked, unfortunately.
@ludeeus Would you like make things easier for others and add support for ARM runners? Seems it'd be appreciated by the general community, especially since ARM runners will likely become the standard, given their benefits over AMD ones.
The maintainer has zero interest in adding ARM support last I and others checked, unfortunately.
Where did i say that?
@ludeeus Would you like make things easier for others and add support for ARM runners? Seems it'd be appreciated by the general community, especially since ARM runners will likely become the standard, given their benefits over AMD ones.
Once github hosted runners are out of preview, this can be added.
Once github hosted runners are out of preview, this can be added.
That seems reasonable; thanks for the quick reply. I'll ping you once this happens. Cheers.
The maintainer has zero interest in adding ARM support last I and others checked, unfortunately.
Where did i say that?
In the PR I submitted a year or two back.
Private/custom runners have supported ARM for a long time. Enterprises use them a lot.
For completeness that PR points to this comment:
Untill GitHub provide action runners for it, this is not sometthing I will add.