OpenComputers icon indicating copy to clipboard operation
OpenComputers copied to clipboard

GUI Boilerplate and Computer Case GUI Beginnings

Open rschulman opened this issue 4 years ago • 14 comments

This draft PR puts in place a few GUI necessities and adds an almost complete case GUI. It does raise some questions about whether we want to make the different case tiers different classes entirely or continue to make them just variables within one class.

rschulman avatar Dec 21 '20 17:12 rschulman

I would like to keep it as variable as there is not really a change between tthe caseses expact the slots

lucsoft avatar Dec 21 '20 17:12 lucsoft

Remeber to update this pr i made big changes (every tecblock is now an blockwithentity)

lucsoft avatar Dec 24 '20 18:12 lucsoft

I'm working on updating it now, but the new CaseEntity doesn't extend BlockEntity directly, so I'm not sure how to override its functions. Right now IDEA is telling me that createMenu (e.g.) overrides nothing. Do you know how I should proceed?

rschulman avatar Dec 26 '20 20:12 rschulman

Hm, slots seem to have scaling issues. I tried to fix it with no luck.

jmi2k avatar Jan 05 '21 12:01 jmi2k

I look into it after im done with my work related stuff

lucsoft avatar Jan 05 '21 12:01 lucsoft

I'm currently copying code from upstream, let's see if that works!

jmi2k avatar Jan 05 '21 12:01 jmi2k

image @rschulman expect a PR soon

jmi2k avatar Jan 05 '21 14:01 jmi2k

Awesome, thanks @jmi2k!

rschulman avatar Jan 05 '21 14:01 rschulman

@jmi2k Just checking in on this. I don't think I've seen a PR from you, unless I'm missing something!

rschulman avatar Jan 17 '21 19:01 rschulman

Its in https://github.com/jmi2k/OpenComputers/tree/fix-ui but keep in mind my focus is on OC2

lucsoft avatar Jan 17 '21 20:01 lucsoft

@rschulman can't you see it here? Did I do something wrong? It's the first time I send PR to different repos from the same fork, maybe I messed up something. @lucsoft what do you mean by OC2?

jmi2k avatar Jan 17 '21 20:01 jmi2k

@jmi2k as in the readme i had teamed up with the Creator of OpenComputers to help bring OpenComputers 2 for Forge & Fabric

lucsoft avatar Jan 17 '21 20:01 lucsoft

Wait there is a v2 of OC in the works! That's amazing!

jmi2k avatar Jan 17 '21 21:01 jmi2k

Wait there is a v2 of OC in the works! That's amazing!

Yes its now a Linux Computer that has a lua runtime

lucsoft avatar Jan 17 '21 21:01 lucsoft