undefined method 'window' for Selenium::Session

[jwoertink]

Upgraded to flow master to try this new stuff out, but getting compile errors:

In spec/support/flows/authenticated_flow.cr:15:13

 15 | session.window.resize_to(2560, 1366)
              ^-----
Error: undefined method 'window' for Selenium::Session

This is related to the new selenium shard. I think the new method is window_manager, but it made me think that we will need to make sure we have a clear upgrade guide on this. So when we do the next release, we will need to document all of the method name changes.

/cc @matthewmcgarvey

[matthewmcgarvey]

This occurred because this library exposes the session from the underlying selenium library. It is not a bug of LuckyFlow, though it is a breaking change.

While looking into this, I did find a bug https://github.com/luckyframework/lucky_flow/pull/82

[paulcsmith]

@jwoertink are you calling “window” directly or is it being called through a LuckyFlow method?

If it’s called directly then I think we could treat this as a documentation thing we need to add to upgrade notes. What do you think?

[jwoertink]

We are calling session.window directly, so we will just need some docs on the upgrade which I'm cool with.

[matthewmcgarvey]

I'll try to get the selenium library documented and the documentation published so that it can be referenced where ever it is needed here.

[matthewmcgarvey]

@jwoertink @paulcsmith This is mostly empty but I've got the api docs for the selenium library published here now https://matthewmcgarvey.github.io/selenium.cr/

[paulcsmith]

NOICE! That will be awesome to link to