pyitau icon indicating copy to clipboard operation
pyitau copied to clipboard

fix get_statements

Open aalbertoni opened this issue 1 year ago • 3 comments

Summary by CodeRabbit

  • Bug Fixes
    • Refined the process of retrieving account statement information to ensure accuracy and stability.

aalbertoni avatar Dec 17 '23 02:12 aalbertoni

Walkthrough

The update in the pyitau codebase refines the way a property retrieves data from HTML. Specifically, it tweaks the full_statement_op property to more accurately target an anchor (<a>) tag based on a specific href attribute value. This ensures the property fetches the correct "data-op" attribute, likely improving the reliability of the operation it's designed to perform.

Changes

File Change Summary
pyitau/pages.py Modified full_statement_op to fetch "data-op" from a specific <a> tag with a defined href.

🐇✨ In the code's woven tapestry, A rabbit tweaked the property. With a hop and a skip, the <a> tag's found, Ensuring the data-op's solid and sound. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

coderabbitai[bot] avatar Dec 17 '23 02:12 coderabbitai[bot]

This PR fixes the get_statements method failing on master. Any chance we could get this merged soon? Thanks! 🙏

rodrimaia avatar Jan 10 '24 17:01 rodrimaia

This PR fixes the get_statements method failing on master. Any chance we could get this merged soon? Thanks! 🙏

I'll fix the tests and merge it.

In the meantime, you can try to use get_statements_from_month. I'm using it daily (here) and didn't have any issues.

lucasrcezimbra avatar Jan 11 '24 12:01 lucasrcezimbra