Lukas Rusak
Test builds: - [ ] [android arm](https://mirrors.kodi.tv/test-builds/android/arm/kodi-20211224-72f1b9fa-PR20604-23701-armeabi-v7a.apk) - [ ] [android arm64](https://mirrors.kodi.tv/test-builds/android/arm64-v8a/kodi-20211224-72f1b9fa-PR20604-20829-arm64-v8a.apk) - [ ] [iOS](https://mirrors.kodi.tv/test-builds/darwin/ios-arm64/kodi-20211224-72f1b9fa-PR20604-17730-ios64.deb) - [ ] [TVOS](https://mirrors.kodi.tv/test-builds/darwin/tvos/kodi-20211224-72f1b9fa-PR20604-8727-tvos.deb) - [ ] [MacOS](https://mirrors.kodi.tv/test-builds/osx/x86_64/kodi-20211224-72f1b9fa-PR20604-23880-x86_64.dmg)
Might be a bug with spdlog. It seems custom level names can only be used with the header only compile. See: https://github.com/gabime/spdlog/blob/4cfdc8c5c84f696774cb9acde2f95c9e87c11a5e/include/spdlog/common-inl.h#L19 https://github.com/gabime/spdlog/blob/4cfdc8c5c84f696774cb9acde2f95c9e87c11a5e/include/spdlog/common.h#L357 https://github.com/xbmc/xbmc/blob/d0db844f8bd64db8f3b68b89891e07b1639e5bec/xbmc/utils/log.h#L14
I think it's fine as is. The only other thing I can say is maybe change to `LOGWARNING` rather than `LOGERROR` but I'm fine either way.
> Seems good. From what I see you didn't checked CRC and it's better that way. Many times CRC is incorrect. I can look into this. Currently the only verification...
Thanks for the PR! A quick overview initially looks ok. I'll need to look a bit deeper though in the future as we have to defer this to V20 as...
you have some diffs to apply for formatting https://jenkins.kodi.tv/job/BuildMulti-PR/18374/
The code style changes should be squashed into the individual commits where the changes took place. Jenkins offers a diff for each commit individually that you can apply as a...
Looking at the code I'm not sure in which case `RenderRGB` will be invoked really. It looks like VDPAU will use it in some case but I'm not 100% sure...
@marianrh it would help to post a debug log. Seems there is something happening when a specific profile isn't supported. ``` 2022-09-16 10:24:16.181 T:29061 ERROR : VAAPI/vpp vaCreateConfig error: the...
@DaVukovic would it be possible for you to split out the clang-format changes for `CJSONServiceDescription::m_methodMaps` into a pre commit? This way your commit changes exactly what is needed.