Edoardo Luppi

Results 459 comments of Edoardo Luppi
trafficstars

This is the patch file I'm using. Also solves a second issue (see in-code comments). [@nx+js+19.6.6.patch](https://github.com/user-attachments/files/16990677/%40nx%2Bjs%2B19.6.6.patch)

This one should be an easy fix, and it looks like the demand exists. Every now and then a new assets-related issue comes up with this exact problem.

Hey @ndcunningham! Thanks for the update. See [this](https://github.com/nrwl/nx/issues/20309#issuecomment-2315183352) comment for the separate executor and why it might not always work.

Thanks, and yup I see A LOT of them sporadically. I'll bump to 19.8.2+ this week and report back.

Remember you can also un-ignore paths using `.nxignore`. Patterns are merged with `.gitignore` ones.

Yeah definitely a bug, I was suggesting nxignore to avoid modifying gitignore.

A good default for the plugin could be creating source sets based on active platforms. Example with `js()` and `jvm()`: ```text commonMain commonTest commonBenchmark jsMain jsTest jsBenchmark jvmMain jvmTest jvmBenchmark...

@fzhinkin thanks for looking into it. Did you notice the slowdown only for the `set` branch, or for both `set` and `slice`? Admittedly I didn't consider very small arrays, but...