Edoardo Luppi

Results 437 comments of Edoardo Luppi
trafficstars

@gaeljw > What I would expect is more option 2 That's fair, however there is something to clarify. Let's say we have ``` feat(my-scope): ``` When you invoke the completion...

@gaeljw yeah, especially if you're on Windows, there are major issues with emojis, which are rendered as monochrome symbols. E.g. https://youtrack.jetbrains.com/issue/JBR-2917 But leaving that aside, it seems you'd want to...

I've implemented highlighting for the header part of the message (type, scope, breaking change, subject). What do you think? Should I expand that also to footers? ![image](https://user-images.githubusercontent.com/19871649/171738374-2d33e8ef-4433-4f5f-8c80-6f3b9e77f3a5.png)

@AVROTROS-developers where would you like to have this checkbox? As a general settings? Or in the commit builder dialog?

Got what the problem is. Easy to fix. Will push an update on the weekend probably.

See commit 9e6420a3e831a5b205e2bf25b999babb272d7f51

@rklec mmmm, that's quite strange. The line is ``` .take(max(MAX_ELEMENTS - footerValues.size, 0)) ``` How can this produce a -2? Maybe I'm getting dumber lol

Ahhh damn. I still have not published the update hahahaha Sorry I totally forgot about this detail.

Hi @avalanche1 Mmmh I'm trying to understand what you're trying to accomplish. Do you want to avoid the completion auto-popup?

@avalanche1 sometimes you just want to search for a previous subject you used, and that's the most straightforward way to do it imho. A registry setting could be good enough...